Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2947303002: [DevTools] Migrate inspector-protocol/{page,dom-snapshot} tests to new harness (Closed)

Created:
3 years, 6 months ago by dgozman
Modified:
3 years, 5 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Migrate inspector-protocol/{page,dom-snapshot} tests to new harness BUG=734762 Review-Url: https://codereview.chromium.org/2947303002 Cr-Commit-Position: refs/heads/master@{#482845} Committed: https://chromium.googlesource.com/chromium/src/+/475ce8ef500505927a1458c6ec1a4971eccdb691

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : unflake #

Patch Set 4 : rebased #

Patch Set 5 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+545 lines, -824 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/dom-snapshot/dom-snapshot-getSnapshot.html View 1 chunk +0 lines, -63 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/dom-snapshot/dom-snapshot-getSnapshot.js View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/dom-snapshot/dom-snapshot-getSnapshot-expected.txt View 1 2 74 chunks +195 lines, -277 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/page/createIsolatedWorld.html View 1 2 1 chunk +0 lines, -73 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/page/createIsolatedWorld.js View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/page/createIsolatedWorld-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/page/enable-disable.html View 1 chunk +0 lines, -66 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/page/enable-disable.js View 1 chunk +33 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/page/enable-disable-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/page/frameAttachedDetached.html View 1 chunk +0 lines, -61 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/page/frameAttachedDetached.js View 1 chunk +25 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/page/frameAttachedDetached-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/page/frameAttachedStacktrace.html View 1 chunk +0 lines, -92 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/page/frameAttachedStacktrace.js View 1 chunk +59 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/page/frameAttachedStacktrace-expected.txt View 2 chunks +1 line, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/page/frameScheduledNavigation.html View 1 chunk +0 lines, -43 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/page/frameScheduledNavigation.js View 1 chunk +21 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/page/frameStartedLoading.html View 1 chunk +0 lines, -36 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/page/frameStartedLoading.js View 1 chunk +15 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/page/get-layout-metrics.html View 1 chunk +0 lines, -40 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/page/get-layout-metrics.js View 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/page/get-layout-metrics-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/page/javascriptDialogEvents.html View 1 chunk +0 lines, -62 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/page/javascriptDialogEvents.js View 1 chunk +35 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/page/javascriptDialogEvents-expected.txt View 1 chunk +1 line, -4 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/resources/dom-snapshot.html View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/resources/frame-attached-stacktrace-page.html View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/resources/simple-iframe.html View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 32 (24 generated)
dgozman
Take a look please.
3 years, 6 months ago (2017-06-21 23:55:59 UTC) #2
pfeldman
lgtm
3 years, 6 months ago (2017-06-22 19:02:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2947303002/20001
3 years, 6 months ago (2017-06-22 21:10:14 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/483727)
3 years, 6 months ago (2017-06-22 23:40:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2947303002/60001
3 years, 5 months ago (2017-06-27 21:50:44 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/475384)
3 years, 5 months ago (2017-06-27 22:05:48 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2947303002/80001
3 years, 5 months ago (2017-06-28 00:07:53 UTC) #28
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 01:40:15 UTC) #32
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/475ce8ef500505927a1458c6ec1a...

Powered by Google App Engine
This is Rietveld 408576698