Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2949423002: Update record_controller to pass memoryDumpConfig to all controller clients. (Closed)

Created:
3 years, 6 months ago by erikchen
Modified:
3 years, 6 months ago
Reviewers:
fmeawad
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org, Primiano Tucci (use gerrit)
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client.html View 2 chunks +3 lines, -7 lines 0 comments Download
M tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client_test.html View 1 chunk +5 lines, -4 lines 0 comments Download
M tracing/tracing/ui/extras/about_tracing/record_controller.html View 1 chunk +7 lines, -0 lines 1 comment Download

Messages

Total messages: 12 (8 generated)
erikchen
fmeawad: Please review.
3 years, 6 months ago (2017-06-23 01:11:51 UTC) #2
fmeawad
LGTM with a comment https://codereview.chromium.org/2949423002/diff/1/tracing/tracing/ui/extras/about_tracing/record_controller.html File tracing/tracing/ui/extras/about_tracing/record_controller.html (right): https://codereview.chromium.org/2949423002/diff/1/tracing/tracing/ui/extras/about_tracing/record_controller.html#newcode99 tracing/tracing/ui/extras/about_tracing/record_controller.html:99: {'mode': 'detailed', 'periodic_interval_ms': 10000}); I ...
3 years, 6 months ago (2017-06-23 17:38:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2949423002/1
3 years, 6 months ago (2017-06-23 17:43:22 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 17:44:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698