Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client_test.html

Issue 2949423002: Update record_controller to pass memoryDumpConfig to all controller clients. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client_test.html
diff --git a/tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client_test.html b/tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client_test.html
index 2126228c9747000e3f67fab95e1800dc1062f726..aa934c928384b8904bb8c775d458fdad18b3e598 100644
--- a/tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client_test.html
+++ b/tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client_test.html
@@ -54,25 +54,26 @@ tr.b.unittest.testSuite(function() {
result.params.traceConfig.recordMode, 'recordUntilFull');
assert.isFalse(
result.params.traceConfig.enableSystrace);
- assert.isTrue(
- result.params.traceConfig.memoryDumpConfig.triggers.length === 0);
+ assert.isFalse('memoryDumpConfig' in result.params.traceConfig);
});
test('beginRecording_sendCategoriesAndOptionsWithMemoryInfra', function() {
const controller = makeController();
+ const memoryConfig = { triggers: [] };
+ memoryConfig.triggers.push(
+ {'mode': 'detailed', 'periodic_interval_ms': 10000});
const recordingOptions = {
included_categories: ['c', 'disabled-by-default-memory-infra', 'a'],
excluded_categories: ['e'],
enable_systrace: false,
record_mode: 'test-mode',
+ memory_dump_config: memoryConfig,
};
const result = JSON.parse(controller.beginRecording(recordingOptions).msg);
assert.isTrue(
result.params.traceConfig.memoryDumpConfig.triggers.length === 1);
- assert.isTrue(
- result.params.traceConfig.memoryDumpConfig.triggers.length === 1);
assert.strictEqual(result.params.traceConfig.memoryDumpConfig.
triggers[0].mode, 'detailed');
assert.strictEqual(result.params.traceConfig.memoryDumpConfig.

Powered by Google App Engine
This is Rietveld 408576698