Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client.html

Issue 2949423002: Update record_controller to pass memoryDumpConfig to all controller clients. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client.html
diff --git a/tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client.html b/tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client.html
index 5056eeb0aca4f264b49cd67c924ec879fb7d521b..170507675ebb98bf59e2c3e426efb0d6f96a1752 100644
--- a/tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client.html
+++ b/tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client.html
@@ -91,12 +91,6 @@ tr.exportTo('tr.ui.e.about_tracing', function() {
throw new Error('Already recording');
}
this.recording_ = 'starting';
- const memoryConfig = { triggers: [] };
- if (recordingOptions.included_categories.indexOf(
- 'disabled-by-default-memory-infra') !== -1) {
- memoryConfig.triggers.push(
- {'mode': 'detailed', 'periodic_interval_ms': 10000});
- }
// The devtools and tracing endpoints have slightly different parameter
// configurations. Noteably, recordMode has different spelling
@@ -117,10 +111,12 @@ tr.exportTo('tr.ui.e.about_tracing', function() {
const traceConfigStr = {
includedCategories: recordingOptions.included_categories,
excludedCategories: recordingOptions.excluded_categories,
- memoryDumpConfig: memoryConfig,
recordMode: RewriteRecordMode(recordingOptions.record_mode),
enableSystrace: recordingOptions.enable_systrace
};
+ if ('memory_dump_config' in recordingOptions) {
+ traceConfigStr.memoryDumpConfig = recordingOptions.memory_dump_config;
+ }
let res = this.conn_.req(
'Tracing.start',
{

Powered by Google App Engine
This is Rietveld 408576698