Basic support for dev_compiler in test.dart.

Basic support for dev_compiler in test.dart.

It can compile and run tests on Chrome. There are a lot of failing tests
that I (or the team) will need to triage, but I think at least basic
tests are working as expected.

There is code that could be cleaned up to more neatly factor how dart2js
and dartdevc are handled now that there are two separate compilers to
JS. There's also some redundant code between the path for testing
compile errors (enqueueStandardTest()) and the path for running a test
in the browser.

R=whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/b452b3996255c388d02edf12924a22fe3b785a1b

[Bob Nystrom, 2017-06-16 22:07:36]

rnystrom@google.com changed reviewers:
+ whesse@google.com

[Bill Hesse, 2017-06-21 16:33:20]

LGTM.

https://codereview.chromium.org/2947473002/diff/20001/tools/testing/dart/brow...
File tools/testing/dart/browser_controller.dart (right):

https://codereview.chromium.org/2947473002/diff/20001/tools/testing/dart/brow...
tools/testing/dart/browser_controller.dart:508: // TODO(rnystrom): Uncomment
this to open the dev tools tab when Chrome
Commented code is disallowed, I think.  You could write it not as code, but as a
pure comment.

https://codereview.chromium.org/2947473002/diff/20001/tools/testing/dart/comm...
File tools/testing/dart/command.dart (right):

https://codereview.chromium.org/2947473002/diff/20001/tools/testing/dart/comm...
tools/testing/dart/command.dart:237: Future<bool> get outputIsUpToDate {
Surely this is better written using keyword async?
But I guess that isn't in the scope of this CL.

https://codereview.chromium.org/2947473002/diff/20001/tools/testing/dart/comp...
File tools/testing/dart/compiler_configuration.dart (right):

https://codereview.chromium.org/2947473002/diff/20001/tools/testing/dart/comp...
tools/testing/dart/compiler_configuration.dart:578: var dir = useSdk ?
"$buildDir/dart-sdk" : "sdk";
This is not currently reachable (the non-sdk case), so if it isn't working, it
should at least have a TODO here.

https://codereview.chromium.org/2947473002/diff/20001/tools/testing/dart/test...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/2947473002/diff/20001/tools/testing/dart/test...
tools/testing/dart/test_suite.dart:822: expectationsMap = {testName:
expectations};
I would initialize the variable with this, and drop the else clause, but you may
disagree.

https://codereview.chromium.org/2947473002/diff/20001/tools/testing/dart/test...
tools/testing/dart/test_suite.dart:1232: var expectation =
expectations[fullTestName];
Nice.

[Bob Nystrom, 2017-06-21 20:18:28]

Thanks!

https://codereview.chromium.org/2947473002/diff/20001/tools/testing/dart/brow...
File tools/testing/dart/browser_controller.dart (right):

https://codereview.chromium.org/2947473002/diff/20001/tools/testing/dart/brow...
tools/testing/dart/browser_controller.dart:508: // TODO(rnystrom): Uncomment
this to open the dev tools tab when Chrome
On 2017/06/21 16:33:20, Bill Hesse wrote:
> Commented code is disallowed, I think.  You could write it not as code, but as
a
> pure comment.

Done.

https://codereview.chromium.org/2947473002/diff/20001/tools/testing/dart/comm...
File tools/testing/dart/command.dart (right):

https://codereview.chromium.org/2947473002/diff/20001/tools/testing/dart/comm...
tools/testing/dart/command.dart:237: Future<bool> get outputIsUpToDate {
On 2017/06/21 16:33:20, Bill Hesse wrote:
> Surely this is better written using keyword async?
> But I guess that isn't in the scope of this CL.

It is a little out of scope, but what the heck. Actually, it doesn't need to be
asynchronous at all. Made it sync, and updated all of the other relevant code.

https://codereview.chromium.org/2947473002/diff/20001/tools/testing/dart/comp...
File tools/testing/dart/compiler_configuration.dart (right):

https://codereview.chromium.org/2947473002/diff/20001/tools/testing/dart/comp...
tools/testing/dart/compiler_configuration.dart:578: var dir = useSdk ?
"$buildDir/dart-sdk" : "sdk";
On 2017/06/21 16:33:20, Bill Hesse wrote:
> This is not currently reachable (the non-sdk case), so if it isn't working, it
> should at least have a TODO here.

Good catch. I think I wrote this before I required useSdk. Removed the non-SDK
case.

https://codereview.chromium.org/2947473002/diff/20001/tools/testing/dart/test...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/2947473002/diff/20001/tools/testing/dart/test...
tools/testing/dart/test_suite.dart:822: expectationsMap = {testName:
expectations};
On 2017/06/21 16:33:20, Bill Hesse wrote:
> I would initialize the variable with this, and drop the else clause, but you
may
> disagree.

I do that sometimes, but I feel a little weird about allocating an object that
gets immediately thrown away in some cases.

https://codereview.chromium.org/2947473002/diff/20001/tools/testing/dart/test...
tools/testing/dart/test_suite.dart:1232: var expectation =
expectations[fullTestName];
On 2017/06/21 16:33:20, Bill Hesse wrote:
> Nice.

:)

Even better is not needing the weird union type for passing expectations around.

[Bob Nystrom, 2017-06-21 20:19:33]

Description was changed from

==========
Basic support for dev_compiler in test.dart.

It can compile and run tests on Chrome. There are a lot of failing tests
that I (or the team) will need to triage, but I think at least basic
tests are working as expected.

There is code that could be cleaned up to more neatly factor how dart2js
and dartdevc are handled now that there are two separate compilers to
JS. There's also some redundant code between the path for testing
compile errors (enqueueStandardTest()) and the path for running a test
in the browser.
==========

to

==========
Basic support for dev_compiler in test.dart.

It can compile and run tests on Chrome. There are a lot of failing tests
that I (or the team) will need to triage, but I think at least basic
tests are working as expected.

There is code that could be cleaned up to more neatly factor how dart2js
and dartdevc are handled now that there are two separate compilers to
JS. There's also some redundant code between the path for testing
compile errors (enqueueStandardTest()) and the path for running a test
in the browser.

R=whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b452b3996255c388d02edf12924a22fe3b785a1b
==========

[Bob Nystrom, 2017-06-21 20:19:34]

Committed patchset #3 (id:40001) manually as
b452b3996255c388d02edf12924a22fe3b785a1b (presubmit successful).