Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: tools/testing/dart/browser_controller.dart

Issue 2947473002: Basic support for dev_compiler in test.dart. (Closed)
Patch Set: Merge branch 'master' into ddc-chrome-tests Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'dart:async'; 5 import 'dart:async';
6 import 'dart:convert'; 6 import 'dart:convert';
7 import 'dart:core'; 7 import 'dart:core';
8 import 'dart:io'; 8 import 'dart:io';
9 import 'dart:math'; 9 import 'dart:math';
10 10
(...skipping 484 matching lines...) Expand 10 before | Expand all | Expand 10 after
495 } 495 }
496 }); 496 });
497 } 497 }
498 }; 498 };
499 var args = [ 499 var args = [
500 "--user-data-dir=${userDir.path}", 500 "--user-data-dir=${userDir.path}",
501 url, 501 url,
502 "--disable-extensions", 502 "--disable-extensions",
503 "--disable-popup-blocking", 503 "--disable-popup-blocking",
504 "--bwsi", 504 "--bwsi",
505 "--no-first-run" 505 "--no-first-run",
506 ]; 506 ];
507
508 // TODO(rnystrom): Uncomment this to open the dev tools tab when Chrome
Bill Hesse 2017/06/21 16:33:20 Commented code is disallowed, I think. You could
Bob Nystrom 2017/06/21 20:18:28 Done.
509 // is spawned. Handy for debugging tests.
510 // args.add("--auto-open-devtools-for-tabs");
511
507 return startBrowserProcess(_binary, args, 512 return startBrowserProcess(_binary, args,
508 environment: _getEnvironment()); 513 environment: _getEnvironment());
509 }); 514 });
510 }).catchError((e) { 515 }).catchError((e) {
511 _logEvent("Running $_binary --version failed with $e"); 516 _logEvent("Running $_binary --version failed with $e");
512 return false; 517 return false;
513 }); 518 });
514 } 519 }
515 520
516 String toString() => "Chrome"; 521 String toString() => "Chrome";
(...skipping 1423 matching lines...) Expand 10 before | Expand all | Expand 10 after
1940 'exit code: ${result.exitCode}\n' 1945 'exit code: ${result.exitCode}\n'
1941 'stdout: ${result.stdout}\n' 1946 'stdout: ${result.stdout}\n'
1942 'stderr: ${result.stderr}'); 1947 'stderr: ${result.stderr}');
1943 } else { 1948 } else {
1944 print('[$message] Successfully uploaded screenshot to $storageUrl'); 1949 print('[$message] Successfully uploaded screenshot to $storageUrl');
1945 } 1950 }
1946 new File(screenshotFile).deleteSync(); 1951 new File(screenshotFile).deleteSync();
1947 } 1952 }
1948 print('--------------------------------------------------------------------'); 1953 print('--------------------------------------------------------------------');
1949 } 1954 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698