Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1082)

Unified Diff: tools/testing/dart/configuration.dart

Issue 2947473002: Basic support for dev_compiler in test.dart. (Closed)
Patch Set: Revise. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/compiler_configuration.dart ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/configuration.dart
diff --git a/tools/testing/dart/configuration.dart b/tools/testing/dart/configuration.dart
index 58791fe31ad4e32dcd2e52560a9e1fbfdbe517c7..b5cd52bc3ae9d24241e9e4a85dae9b1deb6ddbf1 100644
--- a/tools/testing/dart/configuration.dart
+++ b/tools/testing/dart/configuration.dart
@@ -361,6 +361,16 @@ class Configuration {
print("-rflutter is applicable only for --arch=x64");
}
+ if (compiler == Compiler.dartdevc && !useSdk) {
+ isValid = false;
+ print("--compiler dartdevc requires --use-sdk");
+ }
+
+ if (compiler == Compiler.dartdevc && !isStrong) {
+ isValid = false;
+ print("--compiler dartdevc requires --strong");
+ }
+
return isValid;
}
@@ -476,15 +486,23 @@ class Compiler {
static const precompiler = const Compiler._('precompiler');
static const dart2js = const Compiler._('dart2js');
static const dart2analyzer = const Compiler._('dart2analyzer');
+ static const dartdevc = const Compiler._('dartdevc');
static const appJit = const Compiler._('app_jit');
static const dartk = const Compiler._('dartk');
static const dartkp = const Compiler._('dartkp');
static final List<String> names = _all.keys.toList();
- static final _all = new Map<String, Compiler>.fromIterable(
- [none, precompiler, dart2js, dart2analyzer, appJit, dartk, dartkp],
- key: (Compiler compiler) => compiler.name);
+ static final _all = new Map<String, Compiler>.fromIterable([
+ none,
+ precompiler,
+ dart2js,
+ dart2analyzer,
+ dartdevc,
+ appJit,
+ dartk,
+ dartkp
+ ], key: (Compiler compiler) => compiler.name);
static Compiler find(String name) {
var compiler = _all[name];
@@ -522,6 +540,15 @@ class Compiler {
Runtime.safariMobileSim
];
+ case Compiler.dart2js:
+ case Compiler.dartdevc:
+ // TODO(rnystrom): Expand to support other JS execution environments
+ // (other browsers, d8) when tested and working.
+ return const [
+ Runtime.none,
+ Runtime.chrome,
+ ];
+
case Compiler.dart2analyzer:
return const [Runtime.none];
case Compiler.appJit:
« no previous file with comments | « tools/testing/dart/compiler_configuration.dart ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698