Basic support for dev_compiler in test.dart.

tools/testing/dart/command.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 // We need to use the 'io' prefix here, otherwise io.exitCode will shadow
 // CommandOutput.exitCode in subclasses of CommandOutput.
 import 'dart:io' as io;
 
 import 'command_output.dart';
@@ skipping 22 matching lines @@
   static Command browserHtmlTest(
       String url, Configuration configuration, List<String> expectedMessages,
       {bool retry}) {
     return new BrowserHtmlTestCommand._(
         url, configuration, expectedMessages, retry);
   }
 
   static Command compilation(
       String displayName,
       String outputFile,
-      bool neverSkipCompilation,
       List<Uri> bootstrapDependencies,
       String executable,
       List<String> arguments,
-      Map<String, String> environment) {
-    return new CompilationCommand._(
-        displayName,
-        outputFile,
-        neverSkipCompilation,
-        bootstrapDependencies,
-        executable,
-        arguments,
-        environment);
+      Map<String, String> environment,
+      {bool alwaysCompile: false}) {
+    return new CompilationCommand._(displayName, outputFile, alwaysCompile,
+        bootstrapDependencies, executable, arguments, environment);
   }
 
   static Command kernelCompilation(
       String outputFile,
       bool neverSkipCompilation,
       List<Uri> bootstrapDependencies,
       String executable,
       List<String> arguments,
       Map<String, String> environment) {
     return new KernelCompilationCommand._(outputFile, neverSkipCompilation,
@@ skipping 84 matching lines @@
 
   void _buildHashCode(HashCodeBuilder builder) {
     builder.addJson(displayName);
   }
 
   bool _equal(covariant Command other) =>
       hashCode == other.hashCode && displayName == other.displayName;
 
   String toString() => reproductionCommand;
 
-  Future<bool> get outputIsUpToDate => new Future.value(false);
+  bool get outputIsUpToDate => false;
 }
 
 class ProcessCommand extends Command {
   /// Path to the executable of this command.
   String executable;
 
   /// Command line arguments to the executable.
   final List<String> arguments;
 
   /// Environment for the command.
@@ skipping 36 matching lines @@
             : env.write('$key=${escapeCommandLineArgument(value)} '));
     var command = ([executable]..addAll(batchArguments)..addAll(arguments))
         .map(escapeCommandLineArgument)
         .join(' ');
     if (workingDirectory != null) {
       command = "$command (working directory: $workingDirectory)";
     }
     return "$env$command";
   }
 
-  Future<bool> get outputIsUpToDate => new Future.value(false);
+  bool get outputIsUpToDate => false;
 
   /// Arguments that are passed to the process when starting batch mode.
   ///
   /// In non-batch mode, they should be passed before [arguments].
   List<String> get batchArguments => const [];
 }
 
 class CompilationCommand extends ProcessCommand {
   final String _outputFile;
-  final bool _neverSkipCompilation;
+
+  /// If true, then the compilation is run even if the input files are older
+  /// than the output file.
+  final bool _alwaysCompile;
   final List<Uri> _bootstrapDependencies;
 
   CompilationCommand._(
       String displayName,
       this._outputFile,
-      this._neverSkipCompilation,
+      this._alwaysCompile,
       this._bootstrapDependencies,
       String executable,
       List<String> arguments,
       Map<String, String> environmentOverrides)
       : super._(displayName, executable, arguments, environmentOverrides);
 
-  Future<bool> get outputIsUpToDate {
-    if (_neverSkipCompilation) return new Future.value(false);
+  bool get outputIsUpToDate {
+    if (_alwaysCompile) return false;
 
-    Future<List<Uri>> readDepsFile(String path) {
+    List<Uri> readDepsFile(String path) {
       var file = new io.File(new Path(path).toNativePath());
-      if (!file.existsSync()) {
-        return new Future.value(null);
+      if (!file.existsSync()) return null;
+
+      var lines = file.readAsLinesSync();
+      var dependencies = <Uri>[];
+      for (var line in lines) {
+        line = line.trim();
+        if (line.isNotEmpty) {
+          dependencies.add(Uri.parse(line));
+        }
       }
-      return file.readAsLines().then((List<String> lines) {
-        var dependencies = new List<Uri>();
-        for (var line in lines) {
-          line = line.trim();
-          if (line.length > 0) {
-            dependencies.add(Uri.parse(line));
-          }
-        }
-        return dependencies;
-      });
+
+      return dependencies;
     }
 
-    return readDepsFile("$_outputFile.deps").then((dependencies) {
-      if (dependencies != null) {
-        dependencies.addAll(_bootstrapDependencies);
-        var jsOutputLastModified = TestUtils.lastModifiedCache
-            .getLastModified(new Uri(scheme: 'file', path: _outputFile));
-        if (jsOutputLastModified != null) {
-          for (var dependency in dependencies) {
-            var dependencyLastModified =
-                TestUtils.lastModifiedCache.getLastModified(dependency);
-            if (dependencyLastModified == null ||
-                dependencyLastModified.isAfter(jsOutputLastModified)) {
-              return false;
-            }
-          }
-          return true;
-        }
+    var dependencies = readDepsFile("$_outputFile.deps");
+    if (dependencies == null) return false;
+
+    dependencies.addAll(_bootstrapDependencies);
+    var jsOutputLastModified = TestUtils.lastModifiedCache
+        .getLastModified(new Uri(scheme: 'file', path: _outputFile));
+    if (jsOutputLastModified == null) return false;
+
+    for (var dependency in dependencies) {
+      var dependencyLastModified =
+          TestUtils.lastModifiedCache.getLastModified(dependency);
+      if (dependencyLastModified == null ||
+          dependencyLastModified.isAfter(jsOutputLastModified)) {
+        return false;
       }
-      return false;
-    });
+    }
+    return true;
   }
 
   void _buildHashCode(HashCodeBuilder builder) {
     super._buildHashCode(builder);
     builder.addJson(_outputFile);
-    builder.addJson(_neverSkipCompilation);
+    builder.addJson(_alwaysCompile);
     builder.addJson(_bootstrapDependencies);
   }
 
   bool _equal(CompilationCommand other) =>
       super._equal(other) &&
       _outputFile == other._outputFile &&
-      _neverSkipCompilation == other._neverSkipCompilation &&
+      _alwaysCompile == other._alwaysCompile &&
       deepJsonCompare(_bootstrapDependencies, other._bootstrapDependencies);
 }
 
 class KernelCompilationCommand extends CompilationCommand {
   KernelCompilationCommand._(
       String outputFile,
       bool neverSkipCompilation,
       List<Uri> bootstrapDependencies,
       String executable,
       List<String> arguments,
@@ skipping 298 matching lines @@
 
   void _buildHashCode(HashCodeBuilder builder) {
     super._buildHashCode(builder);
     builder.addJson(_link);
     builder.addJson(_target);
   }
 
   bool _equal(MakeSymlinkCommand other) =>
       super._equal(other) && _link == other._link && _target == other._target;
 }