Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2947213003: Signin screen polish in response to UI review (Closed)

Created:
3 years, 6 months ago by Wenzhao (Colin) Zang
Modified:
3 years, 5 months ago
Reviewers:
jdufault
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, rkc
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Signin screen polish in response to UI review The changes here have been shown and confirmed by UX so they will stay unless there's specs update. (1) Add an icon beside 'App' in the header bar. Currently'App' is the only item without an icon. (2) For crbug.com/735660, the ripple shape is changed to round but it's still slightly off the center. I need to contact with UX for a new .svg. (3) Add animation for public session pod expansion and user drop down menu. (4) Other minor style changes. If interested please reference the QA here: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZV-kBQWRQPoA/files/MCHtA7U1iMGr6zkLgIS_GHBTJhNtoz9Axs8 BUG=718159, 735660 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2947213003 Cr-Commit-Position: refs/heads/master@{#482503} Committed: https://chromium.googlesource.com/chromium/src/+/fa06a1a07bfcbdb3b1b1448d376c4d1148cedde2

Patch Set 1 #

Patch Set 2 : changes after meeting with UX #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -29 lines) Patch
A chrome/browser/resources/chromeos/login/images/1x/show-apps.svg View 1 chunk +7 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/login/images/2x/show-apps.svg View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/md_header_bar.css View 5 chunks +10 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/login/md_header_bar.html View 1 chunk +4 lines, -2 lines 0 comments Download
M ui/login/account_picker/md_screen_account_picker.css View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/login/account_picker/md_user_pod_row.css View 1 16 chunks +52 lines, -21 lines 0 comments Download
M ui/login/account_picker/md_user_pod_row.js View 1 3 chunks +10 lines, -1 line 0 comments Download
M ui/login/account_picker/md_user_pod_template.html View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 26 (22 generated)
Wenzhao (Colin) Zang
3 years, 5 months ago (2017-06-26 23:57:00 UTC) #16
jdufault
lgtm
3 years, 5 months ago (2017-06-27 00:55:29 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2947213003/20001
3 years, 5 months ago (2017-06-27 01:15:56 UTC) #23
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 01:32:50 UTC) #26
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fa06a1a07bfcbdb3b1b1448d376c...

Powered by Google App Engine
This is Rietveld 408576698