Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Unified Diff: ui/login/account_picker/md_user_pod_row.js

Issue 2947213003: Signin screen polish in response to UI review (Closed)
Patch Set: changes after meeting with UX Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/login/account_picker/md_user_pod_row.css ('k') | ui/login/account_picker/md_user_pod_template.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/login/account_picker/md_user_pod_row.js
diff --git a/ui/login/account_picker/md_user_pod_row.js b/ui/login/account_picker/md_user_pod_row.js
index 0ac5ea25fa1a85bd94214198d475cf7bfdc854c7..5173f7a9e0b32bbed9a9353ef17485287ffe078e 100644
--- a/ui/login/account_picker/md_user_pod_row.js
+++ b/ui/login/account_picker/md_user_pod_row.js
@@ -2369,6 +2369,8 @@ cr.define('login', function() {
this.querySelector('.info').textContent =
loadTimeData.getStringF('publicAccountInfoFormat',
this.user_.enterpriseDomain);
+ if (this.querySelector('.full-name'))
+ this.querySelector('.full-name').textContent = this.user_.displayName;
},
/** @override */
@@ -2455,7 +2457,6 @@ cr.define('login', function() {
*/
transitionToAdvanced_: function() {
this.classList.add('advanced');
- // TODO(wzang): Add transition animation when its spec becomes available.
},
/**
@@ -3908,6 +3909,14 @@ cr.define('login', function() {
pod.nameElement.style.width = cr.ui.toCssPx(CROS_POD_WIDTH);
nameArea.style.left = cr.ui.toCssPx(0);
nameArea.style.right = 'auto';
+ // For public session pods whose names are cut off, add a banner
+ // which shows the full name upon hovering.
+ if (pod.isPublicSessionPod && !pod.querySelector('.full-name')) {
+ var fullNameContainer = document.createElement('div');
+ fullNameContainer.classList.add('full-name');
+ fullNameContainer.textContent = pod.nameElement.textContent;
+ nameArea.appendChild(fullNameContainer);
+ }
}
// Update info container area for public session pods.
« no previous file with comments | « ui/login/account_picker/md_user_pod_row.css ('k') | ui/login/account_picker/md_user_pod_template.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698