Modify the accessibility highlight manager to account for the text caret being drawn outside of the…

Modify the accessibility highlight manager to account for the text caret being drawn outside of the active window's bounds.

BUG=709686
Review-Url: https://codereview.chromium.org/2945143002
Cr-Commit-Position: refs/heads/master@{#482523}
Committed: https://chromium.googlesource.com/chromium/src/+/3c28d09d1bfb8e09f0e8f2cc164a2922ae67f7ff

[Maajid, 2017-06-21 01:19:38]

Patchset #2 (id:20001) has been deleted

[Maajid, 2017-06-21 01:19:50]

Patchset #1 (id:1) has been deleted

[Maajid, 2017-06-21 21:56:20]

The CQ bit was checked by maajid@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 21:56:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Maajid, 2017-06-21 21:59:56]

The CQ bit was checked by maajid@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 22:00:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Maajid, 2017-06-21 22:17:11]

maajid@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[commit-bot: I haz the power, 2017-06-21 22:41:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 22:41:29]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2017-06-22 04:54:49]

lgtm

https://codereview.chromium.org/2945143002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/accessibility/accessibility_highlight_manager.h
(right):

https://codereview.chromium.org/2945143002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/accessibility/accessibility_highlight_manager.h:76: bool
IsCaretVisible(const gfx::Rect caret_bounds);
nit: const gfx::Rect&

[dmazzoni, 2017-06-22 04:55:10]

dmazzoni@chromium.org changed reviewers:
+ xiyuan@chromium.org

[dmazzoni, 2017-06-22 04:55:11]

+xiyuan for owners review

[xiyuan, 2017-06-22 17:19:14]

lgtm

https://codereview.chromium.org/2945143002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/accessibility/accessibility_highlight_manager.cc
(right):

https://codereview.chromium.org/2945143002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/accessibility/accessibility_highlight_manager.cc:5:
#include
"chrome/browser/chromeos/accessibility/accessibility_highlight_manager.h"
nit: insert an empty line after

[Maajid, 2017-06-22 22:39:21]

The CQ bit was checked by maajid@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 22:40:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 23:14:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 23:14:07]

Dry run: This issue passed the CQ dry run.

[Maajid, 2017-06-27 02:25:17]

https://codereview.chromium.org/2945143002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/accessibility/accessibility_highlight_manager.cc
(right):

https://codereview.chromium.org/2945143002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/accessibility/accessibility_highlight_manager.cc:5:
#include
"chrome/browser/chromeos/accessibility/accessibility_highlight_manager.h"
On 2017/06/22 17:19:13, xiyuan wrote:
> nit: insert an empty line after

Done.

https://codereview.chromium.org/2945143002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/accessibility/accessibility_highlight_manager.h
(right):

https://codereview.chromium.org/2945143002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/accessibility/accessibility_highlight_manager.h:76: bool
IsCaretVisible(const gfx::Rect caret_bounds);
On 2017/06/22 04:54:49, dmazzoni wrote:
> nit: const gfx::Rect&

Done.

[Maajid, 2017-06-27 02:32:35]

The CQ bit was checked by maajid@chromium.org

[Maajid, 2017-06-27 02:32:35]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org,
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2945143002/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2017-06-27 02:32:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 03:05:44]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1498530755242640,
"parent_rev": "43b27537c41a4a777067f80c1792f68331d52527", "commit_rev":
"3c28d09d1bfb8e09f0e8f2cc164a2922ae67f7ff"}

[commit-bot: I haz the power, 2017-06-27 03:05:57]

Description was changed from

==========
Modify the accessibility highlight manager to account for the text caret being
drawn outside of the active window's bounds.

BUG=709686
==========

to

==========
Modify the accessibility highlight manager to account for the text caret being
drawn outside of the active window's bounds.

BUG=709686

Review-Url: https://codereview.chromium.org/2945143002
Cr-Commit-Position: refs/heads/master@{#482523}
Committed:
https://chromium.googlesource.com/chromium/src/+/3c28d09d1bfb8e09f0e8f2cc164a...
==========

[commit-bot: I haz the power, 2017-06-27 03:05:59]

Committed patchset #4 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/3c28d09d1bfb8e09f0e8f2cc164a...