Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5485)

Unified Diff: chrome/browser/chromeos/ui/accessibility_focus_ring_controller.h

Issue 2945143002: Modify the accessibility highlight manager to account for the text caret being drawn outside of the… (Closed)
Patch Set: Rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/ui/accessibility_focus_ring_controller.h
diff --git a/chrome/browser/chromeos/ui/accessibility_focus_ring_controller.h b/chrome/browser/chromeos/ui/accessibility_focus_ring_controller.h
index 9a227566eabc60e100ade401f2ea32819b1e6f05..54d7ea77492c4815ce8bfec3534660b3a5a0b776 100644
--- a/chrome/browser/chromeos/ui/accessibility_focus_ring_controller.h
+++ b/chrome/browser/chromeos/ui/accessibility_focus_ring_controller.h
@@ -68,6 +68,8 @@ class AccessibilityFocusRingController : public FocusRingLayerDelegate {
private:
FRIEND_TEST_ALL_PREFIXES(AccessibilityFocusRingControllerTest,
CursorWorksOnMultipleDisplays);
+ FRIEND_TEST_ALL_PREFIXES(AccessibilityFocusRingControllerTest,
+ CaretRingDrawnOnlyWithinBounds);
// FocusRingLayerDelegate overrides.
void OnDeviceScaleFactorChanged() override;
@@ -81,11 +83,10 @@ class AccessibilityFocusRingController : public FocusRingLayerDelegate {
AccessibilityFocusRing RingFromSortedRects(
const std::vector<gfx::Rect>& rects) const;
- void SplitIntoParagraphShape(
- const std::vector<gfx::Rect>& rects,
- gfx::Rect* top,
- gfx::Rect* middle,
- gfx::Rect* bottom) const;
+ void SplitIntoParagraphShape(const std::vector<gfx::Rect>& rects,
+ gfx::Rect* top,
+ gfx::Rect* middle,
+ gfx::Rect* bottom) const;
bool Intersects(const gfx::Rect& r1, const gfx::Rect& r2) const;
struct LayerAnimationInfo {

Powered by Google App Engine
This is Rietveld 408576698