Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: chrome/browser/chromeos/accessibility/accessibility_highlight_manager.h

Issue 2945143002: Modify the accessibility highlight manager to account for the text caret being drawn outside of the… (Closed)
Patch Set: Rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/accessibility/accessibility_highlight_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/accessibility/accessibility_highlight_manager.h
diff --git a/chrome/browser/chromeos/accessibility/accessibility_highlight_manager.h b/chrome/browser/chromeos/accessibility/accessibility_highlight_manager.h
index facbcbb76448c2bfb2a03033a052d5150aedcb47..81817108ed1466fe53dcdb22746e002e484ebf5b 100644
--- a/chrome/browser/chromeos/accessibility/accessibility_highlight_manager.h
+++ b/chrome/browser/chromeos/accessibility/accessibility_highlight_manager.h
@@ -46,6 +46,8 @@ class AccessibilityHighlightManager
protected:
FRIEND_TEST_ALL_PREFIXES(AccessibilityFocusRingControllerTest,
CursorWorksOnMultipleDisplays);
+ FRIEND_TEST_ALL_PREFIXES(AccessibilityFocusRingControllerTest,
+ CaretRingDrawnOnlyWithinBounds);
// ui::EventHandler overrides:
void OnMouseEvent(ui::MouseEvent* event) override;
@@ -71,6 +73,7 @@ class AccessibilityHighlightManager
virtual bool IsCursorVisible();
private:
+ bool IsCaretVisible(const gfx::Rect& caret_bounds);
void UpdateFocusAndCaretHighlights();
void UpdateCursorHighlight();
« no previous file with comments | « no previous file | chrome/browser/chromeos/accessibility/accessibility_highlight_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698