Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2945093002: Use WebViewHelper::LocalMainFrame where possible. (Closed)

Created:
3 years, 6 months ago by Łukasz Anforowicz
Modified:
3 years, 6 months ago
Reviewers:
dcheng
CC:
chromium-reviews, Yoav Weiss, gavinp+prerender_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, blink-reviews, subresource-filter-reviews_chromium.org, blink-reviews-frames_chromium.org, kinuko+watch, platform-architecture-syd+reviews-web_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use WebViewHelper::LocalMainFrame where possible. This CL was mostly generated mechanically with: $ git grep -l -i helper.*webview.*mainframeimpl -- third_party/WebKit/Source \ | xargs -n 1 sed -i -e \ 's/helper\.WebView()->MainFrameImpl()/helper.LocalMainFrame()/g' # same as above, but with "helper_." instead of "helper." $ git grep -l -i helper.*webview.*mainframeimpl -- third_party/WebKit/Source \ | xargs -n 1 sed -i -e \ 's/helper_\.WebView()->MainFrameImpl()/helper_.LocalMainFrame()/g' $ git cl format The only manual change was to change the constness of WebViewHelper's LocalMainFrame and RemoteMainFrame accessors. BUG=416660 Review-Url: https://codereview.chromium.org/2945093002 Cr-Commit-Position: refs/heads/master@{#481762} Committed: https://chromium.googlesource.com/chromium/src/+/df4550446034859cc1cf083ec826e6351b1dd2e1

Patch Set 1 #

Patch Set 2 : Rebasing... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -179 lines) Patch
M third_party/WebKit/Source/core/frame/FrameTestHelpers.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameTestHelpers.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/ExternalPopupMenuTest.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/BrowserControlsTest.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/DocumentLoaderTest.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/PrerenderingTest.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ScreenWakeLockTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/TextFinderTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ViewportTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/VisualViewportTest.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebDocumentTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameSerializerSanitizationTest.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameSerializerTest.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 101 chunks +110 lines, -130 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 1 5 chunks +5 lines, -7 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (12 generated)
Łukasz Anforowicz
dcheng@, could you PTAL?
3 years, 6 months ago (2017-06-20 21:05:03 UTC) #8
dcheng
Oh. My comment was originally just aimed at the new instances on that CL, but ...
3 years, 6 months ago (2017-06-20 21:12:02 UTC) #9
Łukasz Anforowicz
On 2017/06/20 21:12:02, dcheng wrote: > Oh. My comment was originally just aimed at the ...
3 years, 6 months ago (2017-06-20 21:36:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2945093002/20001
3 years, 6 months ago (2017-06-23 00:07:17 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 01:29:27 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/df4550446034859cc1cf083ec826...

Powered by Google App Engine
This is Rietveld 408576698