third_party/WebKit/Source/core/html/forms/ExternalPopupMenuTest.cpp - Issue 2945093002: Use WebViewHelper::LocalMainFrame where possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/ExternalPopupMenuTest.cpp

Issue 2945093002: Use WebViewHelper::LocalMainFrame where possible. (Closed)

Patch Set: Rebasing... Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameTestHelpers.cpp ('k') | third_party/WebKit/Source/web/tests/BrowserControlsTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/forms/ExternalPopupMenuTest.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/ExternalPopupMenuTest.cpp b/third_party/WebKit/Source/core/html/forms/ExternalPopupMenuTest.cpp

index 5360c0bbc9ceb60b68a3936f12a6249f49b235be..87cec8fbf434f39b66612ff592120ca2825c5f3f 100644

--- a/third_party/WebKit/Source/core/html/forms/ExternalPopupMenuTest.cpp

+++ b/third_party/WebKit/Source/core/html/forms/ExternalPopupMenuTest.cpp

@@ -127,9 +127,7 @@ class ExternalPopupMenuTest : public ::testing::Test {

const ExternalPopupMenuWebFrameClient& Client() const {

return web_frame_client_;

}

- WebLocalFrameBase* MainFrame() const {

- return helper_.WebView()->MainFrameImpl();

- }

+ WebLocalFrameBase* MainFrame() const { return helper_.LocalMainFrame(); }

private:

std::string base_url_;