Move ContentsSize and HasVisibleContent methods from WebFrame to WebLocalFrame.

Move ContentsSize and HasVisibleContent methods from WebFrame to WebLocalFrame.

Most callers already call through WebLocalFrame, except 3 cases:

- The problematic callsite in WebViewImpl::WidenRectWithinPageBounds is
  a known issue already tracked by https://crbug.com/734209;  it is also
  worth noting that the callers of this method exit early if the main
  frame is not local (and therefore this CL should not cause any behavior
  change).

- The callsite in AwRenderViewExt::CheckContentsSize already checks
  if render_view()->GetMainRenderFrame() is null and therefore
  can get the local main frame via RenderFrame::GetWebFrame rather
  than via WebView::MainFrame as before.

- It is okay for the problematic caller in WebFrameTest.cpp to assume
  that (the test-controlled) frames are all local.

No expected behavior change.

BUG=416660
Review-Url: https://codereview.chromium.org/2953193002
Cr-Commit-Position: refs/heads/master@{#482406}
Committed: https://chromium.googlesource.com/chromium/src/+/c469ccc0d54f64ddea96585adee5bd01a54d6af9

[Łukasz Anforowicz, 2017-06-23 00:18:17]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-23 00:18:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 00:48:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-23 00:48:02]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Łukasz Anforowicz, 2017-06-23 04:17:31]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-23 04:17:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 04:34:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-23 04:34:17]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Łukasz Anforowicz, 2017-06-23 04:37:48]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-23 04:37:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 04:50:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-23 04:50:21]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Łukasz Anforowicz, 2017-06-23 23:13:24]

Description was changed from

==========
Move ContentsSize and HasVisibleContent methods from WebFrame to WebLocalFrame.

Most callers already call through WebLocalFrame, except 2 cases:

- The problematic caller in WebViewImpl::WidenRectWithinPageBounds is a
  known issue already tracked by https://crbug.com/734209;  it is also
  worth noting that the callers of this method exit early if the main
  frame is not local (and therefore this CL should cause any behavior
  change).

- It is okay for the problematic caller in WebFrameTest.cpp to assume
  that (the test-controller) frames are all local.

No expected behavior change.

BUG=416660
==========

to

==========
Move ContentsSize and HasVisibleContent methods from WebFrame to WebLocalFrame.

Most callers already call through WebLocalFrame, except 3 cases:

- The problematic callsite in WebViewImpl::WidenRectWithinPageBounds is
  a known issue already tracked by https://crbug.com/734209;  it is also
  worth noting that the callers of this method exit early if the main
  frame is not local (and therefore this CL should cause any behavior
  change).

- The callsite in AwRenderViewExt::CheckContentsSize already checks
  if render_view()->GetMainRenderFrame() is null and therefore
  can get the local main frame via RenderFrame::GetWebFrame rather
  than via WebView::MainFrame as before.

- It is okay for the problematic caller in WebFrameTest.cpp to assume
  that (the test-controlled) frames are all local.

No expected behavior change.

BUG=416660
==========

[Łukasz Anforowicz, 2017-06-23 23:14:09]

lukasza@chromium.org changed reviewers:
+ dcheng@chromium.org

[Łukasz Anforowicz, 2017-06-23 23:14:09]

dcheng@ can you PTAL?

[dcheng, 2017-06-25 07:37:49]

lgtm

https://codereview.chromium.org/2953193002/diff/20001/android_webview/rendere...
File android_webview/renderer/aw_render_view_ext.cc (right):

https://codereview.chromium.org/2953193002/diff/20001/android_webview/rendere...
android_webview/renderer/aw_render_view_ext.cc:62: if (main_frame)
This conditional seems weird; why would there be no web frame attached to a
render frame? We should investigate removing this in a followup.

[Łukasz Anforowicz, 2017-06-26 16:52:49]

lukasza@chromium.org changed reviewers:
+ boliu@chromium.org

[Łukasz Anforowicz, 2017-06-26 16:52:49]

boliu@, could you PTAL @ //android_webview?

https://codereview.chromium.org/2953193002/diff/20001/android_webview/rendere...
File android_webview/renderer/aw_render_view_ext.cc (right):

https://codereview.chromium.org/2953193002/diff/20001/android_webview/rendere...
android_webview/renderer/aw_render_view_ext.cc:62: if (main_frame)
On 2017/06/25 07:37:48, dcheng (OOO Jun 25 - Jul 1) wrote:
> This conditional seems weird; why would there be no web frame attached to a
> render frame? We should investigate removing this in a followup.

Good point - I am trying to do this in
https://codereview.chromium.org/2960663002.

[Łukasz Anforowicz, 2017-06-26 17:14:02]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-26 17:14:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[boliu, 2017-06-26 17:37:40]

On 2017/06/26 16:52:49, Łukasz A. wrote:
> boliu@, could you PTAL @ //android_webview?

lgtm

[Łukasz Anforowicz, 2017-06-26 17:39:38]

The CQ bit was unchecked by lukasza@chromium.org

[Łukasz Anforowicz, 2017-06-26 17:39:41]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2017-06-26 17:39:43]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2953193002/#ps60001
(title: "Rebasing...")

[commit-bot: I haz the power, 2017-06-26 17:39:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2017-06-26 17:40:20]

Description was changed from

==========
Move ContentsSize and HasVisibleContent methods from WebFrame to WebLocalFrame.

Most callers already call through WebLocalFrame, except 3 cases:

- The problematic callsite in WebViewImpl::WidenRectWithinPageBounds is
  a known issue already tracked by https://crbug.com/734209;  it is also
  worth noting that the callers of this method exit early if the main
  frame is not local (and therefore this CL should cause any behavior
  change).

- The callsite in AwRenderViewExt::CheckContentsSize already checks
  if render_view()->GetMainRenderFrame() is null and therefore
  can get the local main frame via RenderFrame::GetWebFrame rather
  than via WebView::MainFrame as before.

- It is okay for the problematic caller in WebFrameTest.cpp to assume
  that (the test-controlled) frames are all local.

No expected behavior change.

BUG=416660
==========

to

==========
Move ContentsSize and HasVisibleContent methods from WebFrame to WebLocalFrame.

Most callers already call through WebLocalFrame, except 3 cases:

- The problematic callsite in WebViewImpl::WidenRectWithinPageBounds is
  a known issue already tracked by https://crbug.com/734209;  it is also
  worth noting that the callers of this method exit early if the main
  frame is not local (and therefore this CL should not cause any behavior
  change).

- The callsite in AwRenderViewExt::CheckContentsSize already checks
  if render_view()->GetMainRenderFrame() is null and therefore
  can get the local main frame via RenderFrame::GetWebFrame rather
  than via WebView::MainFrame as before.

- It is okay for the problematic caller in WebFrameTest.cpp to assume
  that (the test-controlled) frames are all local.

No expected behavior change.

BUG=416660
==========

[commit-bot: I haz the power, 2017-06-26 21:25:10]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1498498781705870,
"parent_rev": "379f637084f5ccfe96bba687afaad8a75f53c3d5", "commit_rev":
"c469ccc0d54f64ddea96585adee5bd01a54d6af9"}

[commit-bot: I haz the power, 2017-06-26 21:25:22]

Description was changed from

==========
Move ContentsSize and HasVisibleContent methods from WebFrame to WebLocalFrame.

Most callers already call through WebLocalFrame, except 3 cases:

- The problematic callsite in WebViewImpl::WidenRectWithinPageBounds is
  a known issue already tracked by https://crbug.com/734209;  it is also
  worth noting that the callers of this method exit early if the main
  frame is not local (and therefore this CL should not cause any behavior
  change).

- The callsite in AwRenderViewExt::CheckContentsSize already checks
  if render_view()->GetMainRenderFrame() is null and therefore
  can get the local main frame via RenderFrame::GetWebFrame rather
  than via WebView::MainFrame as before.

- It is okay for the problematic caller in WebFrameTest.cpp to assume
  that (the test-controlled) frames are all local.

No expected behavior change.

BUG=416660
==========

to

==========
Move ContentsSize and HasVisibleContent methods from WebFrame to WebLocalFrame.

Most callers already call through WebLocalFrame, except 3 cases:

- The problematic callsite in WebViewImpl::WidenRectWithinPageBounds is
  a known issue already tracked by https://crbug.com/734209;  it is also
  worth noting that the callers of this method exit early if the main
  frame is not local (and therefore this CL should not cause any behavior
  change).

- The callsite in AwRenderViewExt::CheckContentsSize already checks
  if render_view()->GetMainRenderFrame() is null and therefore
  can get the local main frame via RenderFrame::GetWebFrame rather
  than via WebView::MainFrame as before.

- It is okay for the problematic caller in WebFrameTest.cpp to assume
  that (the test-controlled) frames are all local.

No expected behavior change.

BUG=416660

Review-Url: https://codereview.chromium.org/2953193002
Cr-Commit-Position: refs/heads/master@{#482406}
Committed:
https://chromium.googlesource.com/chromium/src/+/c469ccc0d54f64ddea96585adee5...
==========

[commit-bot: I haz the power, 2017-06-26 21:25:23]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c469ccc0d54f64ddea96585adee5...