Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Unified Diff: components/signin/core/browser/signin_header_helper_unittest.cc

Issue 2944383006: [Signin] Rename obfuscated_gaia_id into gaia_id (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/signin/core/browser/signin_header_helper.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/signin/core/browser/signin_header_helper_unittest.cc
diff --git a/components/signin/core/browser/signin_header_helper_unittest.cc b/components/signin/core/browser/signin_header_helper_unittest.cc
index 8246c211833082fc45301feeb459a5363f5aa046..bce7793100476f79685c8c2c757dfc04ca242028 100644
--- a/components/signin/core/browser/signin_header_helper_unittest.cc
+++ b/components/signin/core/browser/signin_header_helper_unittest.cc
@@ -243,16 +243,16 @@ TEST_F(SigninHeaderHelperTest, TestDiceInvalidResponseParams) {
TEST_F(SigninHeaderHelperTest, TestBuildDiceResponseParams) {
const char kAuthorizationCode[] = "authorization_code";
const char kEmail[] = "foo@example.com";
- const char kObfuscatedGaiaID[] = "obfuscated_gaia_id";
+ const char kGaiaID[] = "gaia_id";
const int kSessionIndex = 42;
{
// Signin response.
DiceResponseParams params = BuildDiceResponseParams(base::StringPrintf(
"action=SIGNIN,id=%s,email=%s,authuser=%i,authorization_code=%s",
- kObfuscatedGaiaID, kEmail, kSessionIndex, kAuthorizationCode));
+ kGaiaID, kEmail, kSessionIndex, kAuthorizationCode));
EXPECT_EQ(DiceAction::SIGNIN, params.user_intention);
- EXPECT_EQ(kObfuscatedGaiaID, params.obfuscated_gaia_id);
+ EXPECT_EQ(kGaiaID, params.gaia_id);
EXPECT_EQ(kEmail, params.email);
EXPECT_EQ(kSessionIndex, params.session_index);
EXPECT_EQ(kAuthorizationCode, params.authorization_code);
@@ -261,10 +261,10 @@ TEST_F(SigninHeaderHelperTest, TestBuildDiceResponseParams) {
{
// Signout response.
DiceResponseParams params = BuildDiceResponseParams(
- base::StringPrintf("action=SIGNOUT,id=%s,email=%s,authuser=%i",
- kObfuscatedGaiaID, kEmail, kSessionIndex));
+ base::StringPrintf("action=SIGNOUT,id=%s,email=%s,authuser=%i", kGaiaID,
+ kEmail, kSessionIndex));
EXPECT_EQ(DiceAction::SIGNOUT, params.user_intention);
- EXPECT_EQ(kObfuscatedGaiaID, params.obfuscated_gaia_id);
+ EXPECT_EQ(kGaiaID, params.gaia_id);
EXPECT_EQ(kEmail, params.email);
EXPECT_EQ(kSessionIndex, params.session_index);
EXPECT_EQ("", params.authorization_code);
@@ -273,16 +273,16 @@ TEST_F(SigninHeaderHelperTest, TestBuildDiceResponseParams) {
{
// Missing authorization code.
DiceResponseParams params = BuildDiceResponseParams(
- base::StringPrintf("action=SIGNIN,id=%s,email=%s,authuser=%i",
- kObfuscatedGaiaID, kEmail, kSessionIndex));
+ base::StringPrintf("action=SIGNIN,id=%s,email=%s,authuser=%i", kGaiaID,
+ kEmail, kSessionIndex));
EXPECT_EQ(DiceAction::NONE, params.user_intention);
}
{
// Missing non-optional field (email).
DiceResponseParams params = BuildDiceResponseParams(base::StringPrintf(
- "action=SIGNIN,id=%s,authuser=%i,authorization_code=%s",
- kObfuscatedGaiaID, kSessionIndex, kAuthorizationCode));
+ "action=SIGNIN,id=%s,authuser=%i,authorization_code=%s", kGaiaID,
+ kSessionIndex, kAuthorizationCode));
EXPECT_EQ(DiceAction::NONE, params.user_intention);
}
}
« no previous file with comments | « components/signin/core/browser/signin_header_helper.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698