Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2944193002: Generate enum/getters/setters/mappings for flex-wrap (Closed)

Created:
3 years, 6 months ago by shend
Modified:
3 years, 6 months ago
Reviewers:
nainar
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate enum/getters/setters/mappings for flex-wrap Currently, the flex-wrap property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to a 'keyword' field so that its getters/setters can be generated as well. We also generate the EFlexWrap enum and use the generated CSSValueID <-> EFlexWrap mappings. Diff: https://gist.github.com/cf118a1b16d0d7f12b32dbf644be638a/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2944193002 Cr-Commit-Position: refs/heads/master@{#481078} Committed: https://chromium.googlesource.com/chromium/src/+/6e7c6ec4df78665f215e1a267fc89590a8205563

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -51 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 chunk +0 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +0 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (13 generated)
shend
Hi nainar, PTAL
3 years, 6 months ago (2017-06-19 23:25:25 UTC) #4
nainar
lgtm
3 years, 6 months ago (2017-06-19 23:26:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2944193002/1
3 years, 6 months ago (2017-06-20 23:41:30 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-21 01:49:45 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6e7c6ec4df78665f215e1a267fc8...

Powered by Google App Engine
This is Rietveld 408576698