Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2942393002:
Generate enum/getters/setters/mappings for flex-direction (Closed)
|
Created:
3 years, 6 months ago by shend Modified:
3 years, 6 months ago Reviewers:
nainar CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionGenerate enum/getters/setters/mappings for flex-direction
Currently, the flex-direction property is a 'storage_only' field, so
it has no generated public getters/setters.
This patch changes it to a 'keyword' field so that its getters/setters
can be generated as well. We also generate the EFlexDirection enum and
use the generated CSSValueID <-> EFlexDirection mappings.
Diff: https://gist.github.com/297d38d32b4b097536e73f7c1bd1b3d7/revisions
BUG=628043
Review-Url: https://codereview.chromium.org/2942393002
Cr-Original-Commit-Position: refs/heads/master@{#480688}
Committed: https://chromium.googlesource.com/chromium/src/+/d6df17438f4c6ae0a69e5650f63d0cd6c8d72a00
Review-Url: https://codereview.chromium.org/2942393002
Cr-Commit-Position: refs/heads/master@{#480993}
Committed: https://chromium.googlesource.com/chromium/src/+/d98c08f75e5c26f49a9e05e9d0946a2f6d29d3f0
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Retry #
Messages
Total messages: 37 (28 generated)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
shend@chromium.org changed reviewers: + nainar@chromium.org
Hi Naina, PTAL
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by shend@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by shend@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nainar@chromium.org Link to the patchset: https://codereview.chromium.org/2942393002/#ps20001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497923534003470,
"parent_rev": "03f0da9f348e5c19fdb02ce04df9e5c60cc374e3", "commit_rev":
"d6df17438f4c6ae0a69e5650f63d0cd6c8d72a00"}
Message was sent while issue was closed.
Description was changed from ========== Generate enum/getters/setters/mappings for flex-direction Currently, the flex-direction property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to a 'keyword' field so that its getters/setters can be generated as well. We also generate the EFlexDirection enum and use the generated CSSValueID <-> EFlexDirection mappings. Diff: https://gist.github.com/eeb4122cc02ef70ffa09c642cbc86458/revisions BUG=628043 ========== to ========== Generate enum/getters/setters/mappings for flex-direction Currently, the flex-direction property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to a 'keyword' field so that its getters/setters can be generated as well. We also generate the EFlexDirection enum and use the generated CSSValueID <-> EFlexDirection mappings. Diff: https://gist.github.com/eeb4122cc02ef70ffa09c642cbc86458/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2942393002 Cr-Commit-Position: refs/heads/master@{#480688} Committed: https://chromium.googlesource.com/chromium/src/+/d6df17438f4c6ae0a69e5650f63d... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/d6df17438f4c6ae0a69e5650f63d...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2950743002/ by hayato@chromium.org. The reason for reverting is: Build break on "WebKit Mac Builder" https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder/... https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit... e.g. FAILED: blink_heap_unittests Undefined symbols for architecture x86_64: "blink::getJSPropertyName(blink::CSSPropertyID)", referenced from: blink::V8CSSStyleDeclaration::namedPropertyEnumeratorCustom(v8::PropertyCallbackInfo<v8::Array> const&) in libcore_generated.a(V8CSSStyleDeclarationCustom.o) "blink::cssPropertyID(WTF::String const&)", referenced from: blink::CSSComputedStyleDeclaration::getPropertyValue(WTF::String const&) in libcss_0.a(CSSComputedStyleDeclaration.o) .
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Generate enum/getters/setters/mappings for flex-direction Currently, the flex-direction property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to a 'keyword' field so that its getters/setters can be generated as well. We also generate the EFlexDirection enum and use the generated CSSValueID <-> EFlexDirection mappings. Diff: https://gist.github.com/eeb4122cc02ef70ffa09c642cbc86458/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2942393002 Cr-Commit-Position: refs/heads/master@{#480688} Committed: https://chromium.googlesource.com/chromium/src/+/d6df17438f4c6ae0a69e5650f63d... ========== to ========== Generate enum/getters/setters/mappings for flex-direction Currently, the flex-direction property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to a 'keyword' field so that its getters/setters can be generated as well. We also generate the EFlexDirection enum and use the generated CSSValueID <-> EFlexDirection mappings. Diff: https://gist.github.com/297d38d32b4b097536e73f7c1bd1b3d7/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2942393002 Cr-Commit-Position: refs/heads/master@{#480688} Committed: https://chromium.googlesource.com/chromium/src/+/d6df17438f4c6ae0a69e5650f63d... ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by shend@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nainar@chromium.org Link to the patchset: https://codereview.chromium.org/2942393002/#ps40001 (title: "Retry")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497996857427880,
"parent_rev": "0af09891c51edf00a52822907147c23b4f92aba1", "commit_rev":
"d98c08f75e5c26f49a9e05e9d0946a2f6d29d3f0"}
Message was sent while issue was closed.
Description was changed from ========== Generate enum/getters/setters/mappings for flex-direction Currently, the flex-direction property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to a 'keyword' field so that its getters/setters can be generated as well. We also generate the EFlexDirection enum and use the generated CSSValueID <-> EFlexDirection mappings. Diff: https://gist.github.com/297d38d32b4b097536e73f7c1bd1b3d7/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2942393002 Cr-Commit-Position: refs/heads/master@{#480688} Committed: https://chromium.googlesource.com/chromium/src/+/d6df17438f4c6ae0a69e5650f63d... ========== to ========== Generate enum/getters/setters/mappings for flex-direction Currently, the flex-direction property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to a 'keyword' field so that its getters/setters can be generated as well. We also generate the EFlexDirection enum and use the generated CSSValueID <-> EFlexDirection mappings. Diff: https://gist.github.com/297d38d32b4b097536e73f7c1bd1b3d7/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2942393002 Cr-Original-Commit-Position: refs/heads/master@{#480688} Committed: https://chromium.googlesource.com/chromium/src/+/d6df17438f4c6ae0a69e5650f63d... Review-Url: https://codereview.chromium.org/2942393002 Cr-Commit-Position: refs/heads/master@{#480993} Committed: https://chromium.googlesource.com/chromium/src/+/d98c08f75e5c26f49a9e05e9d094... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/d98c08f75e5c26f49a9e05e9d094... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
