Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 2943413003: Generate getters/setters for remaining flex-* properties. (Closed)

Created:
3 years, 6 months ago by shend
Modified:
3 years, 6 months ago
Reviewers:
nainar
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate getters/setters for remaining flex-* properties. This patch changes the following storage_only fields to be primitive or external fields: - flex-basis - flex-grow - flex-shrink so that their getters/setters can be generated. Diff: https://gist.github.com/cdc56f6747da1a925498c52831557fa2/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2943413003 Cr-Commit-Position: refs/heads/master@{#481102} Committed: https://chromium.googlesource.com/chromium/src/+/a20289ff3503b8203af4f9f8a3ce5f30953bbf01

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -33 lines) Patch
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +0 lines, -30 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (13 generated)
shend
Hi nainar, PTAL
3 years, 6 months ago (2017-06-19 23:25:38 UTC) #5
nainar
lgtm
3 years, 6 months ago (2017-06-19 23:26:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2943413003/1
3 years, 6 months ago (2017-06-21 03:19:58 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-21 03:27:10 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a20289ff3503b8203af4f9f8a3ce...

Powered by Google App Engine
This is Rietveld 408576698