PlzNavigate: improve bf navigations metrics

PlzNavigate: improve bf navigations metrics

This CL improves the metrics landed in
https://codereview.chromium.org/2930353005/. It ensures timing metrics
are not recorded for same-document navigations. It also ensures that the
cache flag metric is not captured twice when PlzNavigate is enabled.

BUG=705559
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2944033002
Cr-Commit-Position: refs/heads/master@{#480853}
Committed: https://chromium.googlesource.com/chromium/src/+/4f1dec3a5a8600ab587761bb9f647cc5806297d5

[clamy, 2017-06-19 16:31:26]

Description was changed from

==========
PlzNavigate: improve bf navigations metrics

This CL improves the metrics landed in
https://codereview.chromium.org/2930353005/. It ensures timing metrics
are not recorded for same-document navigations. It also ensures that the
cache flag metric is not captured twice when PlzNavigate is enabled.

BUG=705559
==========

to

==========
PlzNavigate: improve bf navigations metrics

This CL improves the metrics landed in
https://codereview.chromium.org/2930353005/. It ensures timing metrics
are not recorded for same-document navigations. It also ensures that the
cache flag metric is not captured twice when PlzNavigate is enabled.

BUG=705559
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[clamy, 2017-06-19 16:32:14]

The CQ bit was checked by clamy@chromium.org to run a CQ dry run

[clamy, 2017-06-19 16:32:21]

Description was changed from

==========
PlzNavigate: improve bf navigations metrics

This CL improves the metrics landed in
https://codereview.chromium.org/2930353005/. It ensures timing metrics
are not recorded for same-document navigations. It also ensures that the
cache flag metric is not captured twice when PlzNavigate is enabled.

BUG=705559
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
PlzNavigate: improve bf navigations metrics

This CL improves the metrics landed in
https://codereview.chromium.org/2930353005/. It ensures timing metrics
are not recorded for same-document navigations. It also ensures that the
cache flag metric is not captured twice when PlzNavigate is enabled.

BUG=705559
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[clamy, 2017-06-19 16:32:21]

clamy@chromium.org changed reviewers:
+ nasko@chromium.org

[commit-bot: I haz the power, 2017-06-19 16:32:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[clamy, 2017-06-19 16:32:34]

@nasko: PTAL

[commit-bot: I haz the power, 2017-06-19 17:44:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 17:44:38]

Dry run: This issue passed the CQ dry run.

[nasko, 2017-06-19 18:16:55]

LGTM with a nit.

https://codereview.chromium.org/2944033002/diff/1/content/browser/loader/reso...
File content/browser/loader/resource_dispatcher_host_impl.cc (right):

https://codereview.chromium.org/2944033002/diff/1/content/browser/loader/reso...
content/browser/loader/resource_dispatcher_host_impl.cc:2244:
!request->url().SchemeIsBlob()) {
Maybe we can log these only for http/https cases, since other schemes are
unlikely to hit the network. I also think the page load metrics code only
considers http/https, so it will be more consistent with those?

If you end up changing this one, then it will be good to keep it in sync with
the other histogram added in resource_loader.cc.

[clamy, 2017-06-20 15:14:35]

Thanks!

https://codereview.chromium.org/2944033002/diff/1/content/browser/loader/reso...
File content/browser/loader/resource_dispatcher_host_impl.cc (right):

https://codereview.chromium.org/2944033002/diff/1/content/browser/loader/reso...
content/browser/loader/resource_dispatcher_host_impl.cc:2244:
!request->url().SchemeIsBlob()) {
On 2017/06/19 18:16:55, nasko (slow) wrote:
> Maybe we can log these only for http/https cases, since other schemes are
> unlikely to hit the network. I also think the page load metrics code only
> considers http/https, so it will be more consistent with those?
> 
> If you end up changing this one, then it will be good to keep it in sync with
> the other histogram added in resource_loader.cc.

Done.

[clamy, 2017-06-20 15:14:38]

The CQ bit was checked by clamy@chromium.org

[clamy, 2017-06-20 15:14:38]

The patchset sent to the CQ was uploaded after l-g-t-m from nasko@chromium.org
Link to the patchset: https://codereview.chromium.org/2944033002/#ps20001
(title: "Addressed comments")

[commit-bot: I haz the power, 2017-06-20 15:14:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 16:42:05]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497971678244440,
"parent_rev": "f037a45b11ee51d78a78953cb4dae1d1ff4915d1", "commit_rev":
"4f1dec3a5a8600ab587761bb9f647cc5806297d5"}

[commit-bot: I haz the power, 2017-06-20 16:42:18]

Description was changed from

==========
PlzNavigate: improve bf navigations metrics

This CL improves the metrics landed in
https://codereview.chromium.org/2930353005/. It ensures timing metrics
are not recorded for same-document navigations. It also ensures that the
cache flag metric is not captured twice when PlzNavigate is enabled.

BUG=705559
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
PlzNavigate: improve bf navigations metrics

This CL improves the metrics landed in
https://codereview.chromium.org/2930353005/. It ensures timing metrics
are not recorded for same-document navigations. It also ensures that the
cache flag metric is not captured twice when PlzNavigate is enabled.

BUG=705559
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2944033002
Cr-Commit-Position: refs/heads/master@{#480853}
Committed:
https://chromium.googlesource.com/chromium/src/+/4f1dec3a5a8600ab587761bb9f64...
==========

[commit-bot: I haz the power, 2017-06-20 16:42:20]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4f1dec3a5a8600ab587761bb9f64...