Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2930353005: PlzNavigate: Add metrics to understand bf navigations PLT regression (Closed)

Created:
3 years, 6 months ago by clamy
Modified:
3 years, 6 months ago
Reviewers:
Ilya Sherman, nasko
CC:
chromium-reviews, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, asvitkine+watch_chromium.org, rdsmith+watch_chromium.org, loading-reviews_chromium.org, mmenke
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: Add metrics to understand bf navigations PLT regression This CL adds several metrics to investigate why back-forward navigations are taking longer when PlzNavigate is enabled. BUG=705559 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2930353005 Cr-Commit-Position: refs/heads/master@{#479414} Committed: https://chromium.googlesource.com/chromium/src/+/0625ad3449ae08f0304bfb3f7aeffac49e2a92fd

Patch Set 1 #

Total comments: 20

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -0 lines) Patch
M content/browser/frame_host/navigation_handle_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigation_handle_impl.cc View 1 3 chunks +20 lines, -0 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 2 chunks +44 lines, -0 lines 0 comments Download
M content/browser/loader/resource_loader.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 3 chunks +18 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
clamy
@nasko: PTAL. I think this should cover the cases we discussed yesterday. @isherman: PTAL.
3 years, 6 months ago (2017-06-13 14:52:32 UTC) #6
Ilya Sherman
Metrics LGTM % nits: https://codereview.chromium.org/2930353005/diff/1/content/browser/loader/resource_dispatcher_host_impl.cc File content/browser/loader/resource_dispatcher_host_impl.cc (right): https://codereview.chromium.org/2930353005/diff/1/content/browser/loader/resource_dispatcher_host_impl.cc#newcode275 content/browser/loader/resource_dispatcher_host_impl.cc:275: // Used to log the ...
3 years, 6 months ago (2017-06-13 21:38:00 UTC) #9
nasko
LGTM with nits. https://codereview.chromium.org/2930353005/diff/1/content/browser/frame_host/navigation_handle_impl.cc File content/browser/frame_host/navigation_handle_impl.cc (right): https://codereview.chromium.org/2930353005/diff/1/content/browser/frame_host/navigation_handle_impl.cc#newcode704 content/browser/frame_host/navigation_handle_impl.cc:704: ready_to_commit_time_ = base::TimeTicks::Now(); nit: I'd move ...
3 years, 6 months ago (2017-06-13 23:50:08 UTC) #10
clamy
Thanks! https://codereview.chromium.org/2930353005/diff/1/content/browser/frame_host/navigation_handle_impl.cc File content/browser/frame_host/navigation_handle_impl.cc (right): https://codereview.chromium.org/2930353005/diff/1/content/browser/frame_host/navigation_handle_impl.cc#newcode704 content/browser/frame_host/navigation_handle_impl.cc:704: ready_to_commit_time_ = base::TimeTicks::Now(); On 2017/06/13 23:50:07, nasko (slow) ...
3 years, 6 months ago (2017-06-14 13:26:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2930353005/20001
3 years, 6 months ago (2017-06-14 13:27:09 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/199772)
3 years, 6 months ago (2017-06-14 15:27:01 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2930353005/20001
3 years, 6 months ago (2017-06-14 15:29:49 UTC) #18
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 16:30:55 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0625ad3449ae08f0304bfb3f7aef...

Powered by Google App Engine
This is Rietveld 408576698