content/browser/loader/resource_dispatcher_host_impl.cc - Issue 2944033002: PlzNavigate: improve bf navigations metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/resource_dispatcher_host_impl.cc

Issue 2944033002: PlzNavigate: improve bf navigations metrics (Closed)

Patch Set: Addressed comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/loader/resource_dispatcher_host_impl.cc

diff --git a/content/browser/loader/resource_dispatcher_host_impl.cc b/content/browser/loader/resource_dispatcher_host_impl.cc

index 39108877eb551027f55ebfd7e6d29a13dc89690d..548a9af8cc91114ccc62dc9ff4f1828b7b98d734 100644

--- a/content/browser/loader/resource_dispatcher_host_impl.cc

+++ b/content/browser/loader/resource_dispatcher_host_impl.cc

@@ -2240,7 +2240,8 @@ void ResourceDispatcherHostImpl::BeginRequestInternal(

// TODO(clamy): Remove this once we understand the reason behind the

// back-forward PLT regression with PlzNavigate

if ((info->GetPageTransition() & ui::PAGE_TRANSITION_FORWARD_BACK) &&

- IsResourceTypeFrame(info->GetResourceType())) {

+ IsResourceTypeFrame(info->GetResourceType()) &&

+ request->url().SchemeIsHTTPOrHTTPS()) {

LogBackForwardNavigationFlagsHistogram(request->load_flags());

}