Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2942653002: [css-typed-om] remove asMatrix() method in CSSTransformComponent.idl (Closed)

Created:
3 years, 6 months ago by Hwanseung Lee
Modified:
3 years, 6 months ago
Reviewers:
meade_UTC10
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-typed-om] remove asMatrix() method in CSSTransformComponent.idl asMatrix() was removed in spec[1]. so it should remove at idl. [1] https://drafts.css-houdini.org/css-typed-om-1/#csstransformcomponent BUG=545318

Patch Set 1 #

Patch Set 2 : [css-typed-om] remove asMatrix in CSSTransformComponent.idl #

Patch Set 3 : rebase #

Messages

Total messages: 17 (15 generated)
Hwanseung Lee
@meade PTAL, thank you. PS. asMatrix() function used to make DOMMatrix in CSSTransformValue.cpp. (https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/css/cssom/CSSTransformValue.cpp?dr=CSs&l=39) i ...
3 years, 6 months ago (2017-06-14 23:43:31 UTC) #16
meade_UTC10
3 years, 6 months ago (2017-06-15 04:55:40 UTC) #17
not lgtm

I have a CL that was lgtm'd yesterday that does almost exactly this, including
making AsMatrix return a DOMMatrix... https://codereview.chromium.org/2933473003

I've been making some big changes to Typed OM lately, so would you mind taking a
look at something else for a while, perhaps the Properties and Values stuff I
suggested?

Cheers
meade

Powered by Google App Engine
This is Rietveld 408576698