Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: third_party/WebKit/LayoutTests/typedcssom/cssRotation.html

Issue 2942653002: [css-typed-om] remove asMatrix() method in CSSTransformComponent.idl (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/typedcssom/cssRotation.html
diff --git a/third_party/WebKit/LayoutTests/typedcssom/cssRotation.html b/third_party/WebKit/LayoutTests/typedcssom/cssRotation.html
index bb4a4f1c3e45546503c9e059cb1f1e9458735495..beda6d6b7242230096689bef3dd8edd7d0c28244 100644
--- a/third_party/WebKit/LayoutTests/typedcssom/cssRotation.html
+++ b/third_party/WebKit/LayoutTests/typedcssom/cssRotation.html
@@ -10,35 +10,23 @@ function angle(deg) {
var values = [
{input: new CSSRotation(angle(0)), angle: 0, x: 0, y: 0, z: 1,
- is2D: true, cssText: "rotate(0deg)",
- asMatrix: new CSSMatrixComponent(new DOMMatrixReadOnly([1, 0, 0, 1, 0, 0]))},
+ is2D: true, cssText: "rotate(0deg)"},
{input: new CSSRotation(angle(10)), angle: 10, x: 0, y: 0, z: 1,
- is2D: true, cssText: "rotate(10deg)",
- asMatrix: new CSSMatrixComponent(new DOMMatrixReadOnly([0.9848077, 0.1736481, -0.1736481, 0.9848077, 0, 0]))},
+ is2D: true, cssText: "rotate(10deg)"},
{input: new CSSRotation(angle(-21)), angle: -21, x: 0, y: 0, z: 1,
- is2D: true, cssText: "rotate(-21deg)",
- asMatrix: new CSSMatrixComponent(new DOMMatrixReadOnly([0.9335804, -0.3583679, 0.3583679, 0.9335804, 0, 0]))},
+ is2D: true, cssText: "rotate(-21deg)"},
{input: new CSSRotation(angle(3.2)), angle: 3.2, x: 0, y: 0, z: 1,
- is2D: true, cssText: "rotate(3.2deg)",
- asMatrix: new CSSMatrixComponent(new DOMMatrixReadOnly([0.9984407, 0.0558215, -0.0558215, 0.9984407, 0, 0]))},
+ is2D: true, cssText: "rotate(3.2deg)"},
{input: new CSSRotation(0, 0, 1, angle(90)), angle: 90, x: 0, y: 0, z: 1,
- is2D: false, cssText: "rotate3d(0, 0, 1, 90deg)",
- asMatrix: new CSSMatrixComponent(new DOMMatrixReadOnly([0, 1, 0, 0, -1, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1]))},
+ is2D: false, cssText: "rotate3d(0, 0, 1, 90deg)"},
{input: new CSSRotation(2.7, -3, 4.4, angle(0)), angle: 0, x: 2.7, y: -3, z: 4.4,
- is2D: false, cssText: "rotate3d(2.7, -3, 4.4, 0deg)",
- asMatrix: new CSSMatrixComponent(new DOMMatrixReadOnly([1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1]))},
+ is2D: false, cssText: "rotate3d(2.7, -3, 4.4, 0deg)"},
{input: new CSSRotation(2, 3, 4, angle(10)), angle: 10, x: 2, y: 3, z: 4,
- is2D: false, cssText: "rotate3d(2, 3, 4, 10deg)",
- asMatrix: new CSSMatrixComponent(new DOMMatrixReadOnly([0.9869032, 0.1321258, -0.0925460, 0, -0.1258394,
- 0.9895225, 0.0707777, 0, 0.1009279, -0.0582048, 0.9931896, 0, 0, 0, 0, 1]))},
+ is2D: false, cssText: "rotate3d(2, 3, 4, 10deg)"},
{input: new CSSRotation(2, 3.7, -4, angle(-1.2)), angle: -1.2, x: 2, y: 3.7, z: -4,
- is2D: false, cssText: "rotate3d(2, 3.7, -4, -1.2deg)",
- asMatrix: new CSSMatrixComponent(new DOMMatrixReadOnly([0.9998067, 0.01448049, 0.0132978, 0, -0.0143841,
- 0.9998698, -0.0073125, 0, -0.0134019, 0.0071198, 0.9998848, 0, 0, 0, 0, 1]))},
+ is2D: false, cssText: "rotate3d(2, 3.7, -4, -1.2deg)"},
{input: new CSSRotation(1, 0, 0, new CSSUnitValue(0.5, 'turn')), angle: 180, x: 1, y: 0, z: 0,
- is2D: false, cssText: "rotate3d(1, 0, 0, 0.5turn)",
- asMatrix: new CSSMatrixComponent(new DOMMatrixReadOnly([1, 0, 0, 0, 0, -1, 1.2246467991473532e-16, 0, 0,
- -1.2246467991473532e-16, -1, 0, 0, 0, 0, 1]))}
+ is2D: false, cssText: "rotate3d(1, 0, 0, 0.5turn)"}
];
test(function() {
@@ -62,25 +50,6 @@ test(function() {
}
}, "Test that toString values for CSSRotation is correct.");
-test(function() {
- for (var i = 0; i < values.length; ++i) {
- var input = values[i].input;
- var inputAsMatrix = input.asMatrix();
- assert_equals(inputAsMatrix.is2D(), input.is2D());
- var expectedMatrix = values[i].asMatrix;
- for (var attribute in expectedMatrix) {
- if (attribute == "matrix") {
- assert_matrix_approx_equals(inputAsMatrix[attribute], expectedMatrix[attribute]);
- } else if (attribute != "toString") {
- // Due to the complex trigonometric calculations required for a CSSRotation matrix,
- // the 6 significant figures of each value in the toString might be different.
- // Hence, do not check toString.
- assert_equals(inputAsMatrix[attribute], expectedMatrix[attribute]);
- }
- }
- }
-}, "Test that asMatrix is constructed correctly for CSSRotation.");
-
function assert_array_approx_equals(actual, expected) {
for (var i = 0; i < actual.length; i++) {
assert_approx_equals(actual[i], expected[i], EPSILON);

Powered by Google App Engine
This is Rietveld 408576698