Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2942553002: Remove WebContentsDelegateAndroid::OnGoToEntryOffset (Closed)

Created:
3 years, 6 months ago by ingemara
Modified:
3 years, 6 months ago
Reviewers:
boliu
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WebContentsDelegateAndroid::OnGoToEntryOffset It was added by Opera in https://codereview.chromium.org/684133007, but has since stopped being used downstream. There are no references to the method in any upstream code. BUG= Review-Url: https://codereview.chromium.org/2942553002 Cr-Commit-Position: refs/heads/master@{#479637} Committed: https://chromium.googlesource.com/chromium/src/+/ac91c502638e47cbf801f14eb27e2d725e69bf3c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java View 1 chunk +0 lines, -5 lines 0 comments Download
M components/web_contents_delegate_android/web_contents_delegate_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/web_contents_delegate_android/web_contents_delegate_android.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
ingemara
PTAL, should be a trivial change.
3 years, 6 months ago (2017-06-14 09:07:31 UTC) #3
boliu
lgtm
3 years, 6 months ago (2017-06-14 16:00:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2942553002/1
3 years, 6 months ago (2017-06-15 07:05:46 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 08:15:41 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ac91c502638e47cbf801f14eb27e...

Powered by Google App Engine
This is Rietveld 408576698