Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1557)

Side by Side Diff: components/web_contents_delegate_android/web_contents_delegate_android.cc

Issue 2942553002: Remove WebContentsDelegateAndroid::OnGoToEntryOffset (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/web_contents_delegate_android/web_contents_delegate_android.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/web_contents_delegate_android/web_contents_delegate_android .h" 5 #include "components/web_contents_delegate_android/web_contents_delegate_android .h"
6 6
7 #include <android/keycodes.h> 7 #include <android/keycodes.h>
8 8
9 #include "base/android/jni_android.h" 9 #include "base/android/jni_android.h"
10 #include "base/android/jni_array.h" 10 #include "base/android/jni_array.h"
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 JNIEnv* env = AttachCurrentThread(); 198 JNIEnv* env = AttachCurrentThread();
199 ScopedJavaLocalRef<jobject> obj = GetJavaDelegate(env); 199 ScopedJavaLocalRef<jobject> obj = GetJavaDelegate(env);
200 if (obj.is_null()) 200 if (obj.is_null())
201 return true; 201 return true;
202 ScopedJavaLocalRef<jstring> java_url = 202 ScopedJavaLocalRef<jstring> java_url =
203 ConvertUTF8ToJavaString(env, target_url.spec()); 203 ConvertUTF8ToJavaString(env, target_url.spec());
204 return Java_WebContentsDelegateAndroid_shouldCreateWebContents(env, obj, 204 return Java_WebContentsDelegateAndroid_shouldCreateWebContents(env, obj,
205 java_url); 205 java_url);
206 } 206 }
207 207
208 bool WebContentsDelegateAndroid::OnGoToEntryOffset(int offset) {
209 JNIEnv* env = AttachCurrentThread();
210 ScopedJavaLocalRef<jobject> obj = GetJavaDelegate(env);
211 if (obj.is_null())
212 return true;
213 return Java_WebContentsDelegateAndroid_onGoToEntryOffset(env, obj, offset);
214 }
215
216 void WebContentsDelegateAndroid::WebContentsCreated( 208 void WebContentsDelegateAndroid::WebContentsCreated(
217 WebContents* source_contents, 209 WebContents* source_contents,
218 int opener_render_process_id, 210 int opener_render_process_id,
219 int opener_render_frame_id, 211 int opener_render_frame_id,
220 const std::string& frame_name, 212 const std::string& frame_name,
221 const GURL& target_url, 213 const GURL& target_url,
222 WebContents* new_contents, 214 WebContents* new_contents,
223 const base::Optional<content::WebContents::CreateParams>& create_params) { 215 const base::Optional<content::WebContents::CreateParams>& create_params) {
224 JNIEnv* env = AttachCurrentThread(); 216 JNIEnv* env = AttachCurrentThread();
225 ScopedJavaLocalRef<jobject> obj = GetJavaDelegate(env); 217 ScopedJavaLocalRef<jobject> obj = GetJavaDelegate(env);
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
414 validation_message_bubble_->SetPositionRelativeToAnchor( 406 validation_message_bubble_->SetPositionRelativeToAnchor(
415 rwhv->GetRenderWidgetHost(), anchor_in_root_view); 407 rwhv->GetRenderWidgetHost(), anchor_in_root_view);
416 } 408 }
417 } 409 }
418 410
419 void WebContentsDelegateAndroid::RequestAppBannerFromDevTools( 411 void WebContentsDelegateAndroid::RequestAppBannerFromDevTools(
420 content::WebContents* web_contents) { 412 content::WebContents* web_contents) {
421 } 413 }
422 414
423 } // namespace web_contents_delegate_android 415 } // namespace web_contents_delegate_android
OLDNEW
« no previous file with comments | « components/web_contents_delegate_android/web_contents_delegate_android.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698