components/web_contents_delegate_android/web_contents_delegate_android.h - Issue 2942553002: Remove WebContentsDelegateAndroid::OnGoToEntryOffset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_contents_delegate_android/web_contents_delegate_android.h

Issue 2942553002: Remove WebContentsDelegateAndroid::OnGoToEntryOffset (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java ('k') | components/web_contents_delegate_android/web_contents_delegate_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/web_contents_delegate_android/web_contents_delegate_android.h

diff --git a/components/web_contents_delegate_android/web_contents_delegate_android.h b/components/web_contents_delegate_android/web_contents_delegate_android.h

index 4b179ac46f6a54c90da71ff9836346c5f7f9639e..12a64f8a0101369533197ee13dde19e5183b442d 100644

--- a/components/web_contents_delegate_android/web_contents_delegate_android.h

+++ b/components/web_contents_delegate_android/web_contents_delegate_android.h

@@ -94,7 +94,6 @@ class WebContentsDelegateAndroid : public content::WebContentsDelegate {

const GURL& target_url,

const std::string& partition_id,

content::SessionStorageNamespace* session_storage_namespace) override;

- bool OnGoToEntryOffset(int offset) override;

void CloseContents(content::WebContents* source) override;

void MoveContents(content::WebContents* source,

const gfx::Rect& pos) override;