More strong mode cleaning in dart2js.

More strong mode cleaning in dart2js.

R=efortuna@google.com

Committed: https://github.com/dart-lang/sdk/commit/fe2365584b7e7522276afa80b758d544f2bb864c

[ahe, 2017-06-14 13:27:04]

ahe@google.com changed reviewers:
+ johnniwinther@google.com

[ahe, 2017-06-14 13:27:05]

I only had time for a few more before leaving. I'll continue tomorrow.

[ahe, 2017-06-14 17:09:24]

ahe@google.com changed reviewers:
+ efortuna@google.com

[Emily Fortuna, 2017-06-14 17:24:23]

lgtm after comment

https://codereview.chromium.org/2941763002/diff/1/pkg/compiler/lib/src/compil...
File pkg/compiler/lib/src/compile_time_constants.dart (right):

https://codereview.chromium.org/2941763002/diff/1/pkg/compiler/lib/src/compil...
pkg/compiler/lib/src/compile_time_constants.dart:1002: dynamic firstArgument =
normalizedArguments[0].value;
can we type this ConstantValue instead of dynamic?

[ahe, 2017-06-14 18:38:25]

https://codereview.chromium.org/2941763002/diff/1/pkg/compiler/lib/src/compil...
File pkg/compiler/lib/src/compile_time_constants.dart (right):

https://codereview.chromium.org/2941763002/diff/1/pkg/compiler/lib/src/compil...
pkg/compiler/lib/src/compile_time_constants.dart:1002: dynamic firstArgument =
normalizedArguments[0].value;
On 2017/06/14 17:24:23, Emily Fortuna wrote:
> can we type this ConstantValue instead of dynamic?

It's assumed to be StringSomething further down.

[ahe, 2017-06-15 07:34:53]

Description was changed from

==========
More strong mode cleaning in dart2js.
==========

to

==========
More strong mode cleaning in dart2js.

R=efortuna@google.com

Committed:
https://github.com/dart-lang/sdk/commit/fe2365584b7e7522276afa80b758d544f2bb864c
==========

[ahe, 2017-06-15 07:34:54]

Committed patchset #1 (id:1) manually as
fe2365584b7e7522276afa80b758d544f2bb864c (presubmit successful).