More strong mode cleaning in dart2js.

pkg/compiler/lib/src/compile_time_constants.dart

Index: pkg/compiler/lib/src/compile_time_constants.dart
diff --git a/pkg/compiler/lib/src/compile_time_constants.dart b/pkg/compiler/lib/src/compile_time_constants.dart
index 02576e09e63bb4c136a049b0d1aa5246b78682e1..2b56fd7b14cbb441ae693f020d0dfd9ca03b55bc 100644
--- a/pkg/compiler/lib/src/compile_time_constants.dart
+++ b/pkg/compiler/lib/src/compile_time_constants.dart
@@ -999,7 +999,7 @@ class CompileTimeConstantEvaluator extends Visitor<AstConstant> {
       CallStructure callStructure,
       List<AstConstant> normalizedArguments,
       List<AstConstant> concreteArguments) {
-    var firstArgument = normalizedArguments[0].value;
+    dynamic firstArgument = normalizedArguments[0].value;

[Emily Fortuna, 2017/06/14 17:24:23]

can we type this ConstantValue instead of dynamic?

[ahe, 2017/06/14 18:38:24]

It's assumed to be StringSomething further down.

     ConstantValue defaultValue = normalizedArguments[1].value;
 
     if (firstArgument.isNull) {
@@ -1239,7 +1239,8 @@ class ConstructorEvaluator extends CompileTimeConstantEvaluator {
     // Assign arguments to parameters.
     FunctionSignature signature = constructor.functionSignature;
     int index = 0;
-    signature.orderedForEachParameter((ParameterElement parameter) {
+    signature.orderedForEachParameter((_parameter) {
+      ParameterElement parameter = _parameter;
       AstConstant argument = arguments[index++];
       Node node = parameter.node;
       if (parameter.isInitializingFormal) {
@@ -1265,7 +1266,8 @@ class ConstructorEvaluator extends CompileTimeConstantEvaluator {
 
       Map<FieldEntity, ConstantExpression> fields =
           expression.computeInstanceFields(new _CompilerEnvironment(compiler));
-      fields.forEach((FieldElement field, ConstantExpression expression) {
+      fields.forEach((_field, ConstantExpression expression) {
+        FieldElement field = _field;
         ConstantValue value = expression.evaluate(
             new _CompilerEnvironment(compiler), constantSystem);
         fieldValues[field] = new AstConstant(context, null, expression, value);