Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2934333002: More dart2js strong mode cleanup. (Closed)

Created:
3 years, 6 months ago by ahe
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Restore ignore for non-strong mode. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -80 lines) Patch
M pkg/compiler/lib/src/elements/elements.dart View 3 chunks +11 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_engine.dart View 6 chunks +13 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_visitor.dart View 1 5 chunks +8 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 3 chunks +8 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_strategy.dart View 3 chunks +6 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor.dart View 1 chunk +7 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart View 3 chunks +15 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 10 chunks +21 lines, -19 lines 0 comments Download
M pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/testing_strong.json View 1 chunk +17 lines, -6 lines 0 comments Download
M pkg/front_end/test/fasta/testing.json View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ahe
3 years, 6 months ago (2017-06-14 19:41:20 UTC) #2
Emily Fortuna
lgtm https://codereview.chromium.org/2934333002/diff/1/pkg/compiler/lib/src/kernel/kernel_visitor.dart File pkg/compiler/lib/src/kernel/kernel_visitor.dart (left): https://codereview.chromium.org/2934333002/diff/1/pkg/compiler/lib/src/kernel/kernel_visitor.dart#oldcode2894 pkg/compiler/lib/src/kernel/kernel_visitor.dart:2894: return variable; we remove this return statement, too?
3 years, 6 months ago (2017-06-14 20:31:20 UTC) #3
ahe
Thank you, Emily! https://codereview.chromium.org/2934333002/diff/1/pkg/compiler/lib/src/kernel/kernel_visitor.dart File pkg/compiler/lib/src/kernel/kernel_visitor.dart (left): https://codereview.chromium.org/2934333002/diff/1/pkg/compiler/lib/src/kernel/kernel_visitor.dart#oldcode2894 pkg/compiler/lib/src/kernel/kernel_visitor.dart:2894: return variable; On 2017/06/14 20:31:20, Emily ...
3 years, 6 months ago (2017-06-14 20:46:58 UTC) #4
ahe
3 years, 6 months ago (2017-06-15 07:42:29 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
06b8ce5d345459d6b35fe62143284043eee47411 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698