Starting making dart2js strong mode clean.

Start making dart2js strong mode clean.

R=efortuna@google.com

Committed: https://github.com/dart-lang/sdk/commit/87700d381c53e533b038e51f3072d2fed5f5ac59

[ahe, 2017-06-14 13:10:28]

ahe@google.com changed reviewers:
+ johnniwinther@google.com

[ahe, 2017-06-14 17:08:54]

ahe@google.com changed reviewers:
+ efortuna@google.com

[Emily Fortuna, 2017-06-14 17:42:52]

lgtm post-comments

https://codereview.chromium.org/2938823002/diff/1/pkg/compiler/lib/src/native...
File pkg/compiler/lib/src/native/behavior.dart (right):

https://codereview.chromium.org/2938823002/diff/1/pkg/compiler/lib/src/native...
pkg/compiler/lib/src/native/behavior.dart:526: dynamic specArgument =
argNodes.head;
this should be type Node

https://codereview.chromium.org/2938823002/diff/1/pkg/compiler/lib/src/native...
pkg/compiler/lib/src/native/behavior.dart:533: dynamic codeArgument =
argNodes.tail.head;
same here

https://codereview.chromium.org/2938823002/diff/1/pkg/compiler/lib/src/util/m...
File pkg/compiler/lib/src/util/maplet.dart (right):

https://codereview.chromium.org/2938823002/diff/1/pkg/compiler/lib/src/util/m...
pkg/compiler/lib/src/util/maplet.dart:10: static const dynamic _MARKER = const
_MapletMarker();
remove dynamic here and move it down to line 25?

https://codereview.chromium.org/2938823002/diff/1/pkg/compiler/lib/src/util/m...
pkg/compiler/lib/src/util/maplet.dart:25: var _key = _MARKER;
dynamic _key = _MARKER;

?

https://codereview.chromium.org/2938823002/diff/1/pkg/compiler/lib/src/util/s...
File pkg/compiler/lib/src/util/setlet.dart (right):

https://codereview.chromium.org/2938823002/diff/1/pkg/compiler/lib/src/util/s...
pkg/compiler/lib/src/util/setlet.dart:10: static const dynamic _MARKER = const
_SetletMarker();
remove the dynamic here and move dynamic to line below

https://codereview.chromium.org/2938823002/diff/1/pkg/compiler/lib/src/util/s...
pkg/compiler/lib/src/util/setlet.dart:22: var _contents = _MARKER;
dynamic _contents = _MARKER;

[ahe, 2017-06-14 18:27:23]

Thank you, Emily. I was able to change _MARKER, but see my comments below. PTAL

https://codereview.chromium.org/2938823002/diff/1/pkg/compiler/lib/src/native...
File pkg/compiler/lib/src/native/behavior.dart (right):

https://codereview.chromium.org/2938823002/diff/1/pkg/compiler/lib/src/native...
pkg/compiler/lib/src/native/behavior.dart:526: dynamic specArgument =
argNodes.head;
On 2017/06/14 17:42:51, Emily Fortuna wrote:
> this should be type Node

That's what's inferred, but that type is not compatible with the assumption that
specArgument is a StringNode below.

What I'm trying to do here is go quickly through dart2js and make as small
changes as possible, and I think using dynamic is the safest way to that.
Someone can do another pass to remove dynamic, but consider that this code is
going to be replaced by the shared front-end.

https://codereview.chromium.org/2938823002/diff/1/pkg/compiler/lib/src/util/m...
File pkg/compiler/lib/src/util/maplet.dart (right):

https://codereview.chromium.org/2938823002/diff/1/pkg/compiler/lib/src/util/m...
pkg/compiler/lib/src/util/maplet.dart:10: static const dynamic _MARKER = const
_MapletMarker();
On 2017/06/14 17:42:51, Emily Fortuna wrote:
> remove dynamic here and move it down to line 25?

Done.

https://codereview.chromium.org/2938823002/diff/1/pkg/compiler/lib/src/util/m...
pkg/compiler/lib/src/util/maplet.dart:25: var _key = _MARKER;
On 2017/06/14 17:42:52, Emily Fortuna wrote:
> dynamic _key = _MARKER;
> 
> ?

Done.

https://codereview.chromium.org/2938823002/diff/1/pkg/compiler/lib/src/util/s...
File pkg/compiler/lib/src/util/setlet.dart (right):

https://codereview.chromium.org/2938823002/diff/1/pkg/compiler/lib/src/util/s...
pkg/compiler/lib/src/util/setlet.dart:10: static const dynamic _MARKER = const
_SetletMarker();
On 2017/06/14 17:42:52, Emily Fortuna wrote:
> remove the dynamic here and move dynamic to line below

Done.

https://codereview.chromium.org/2938823002/diff/1/pkg/compiler/lib/src/util/s...
pkg/compiler/lib/src/util/setlet.dart:22: var _contents = _MARKER;
On 2017/06/14 17:42:52, Emily Fortuna wrote:
> dynamic _contents = _MARKER;

Done.

[ahe, 2017-06-14 18:28:38]

Description was changed from

==========
Starting making dart2js strong mode clean.
==========

to

==========
Start making dart2js strong mode clean.
==========

[Emily Fortuna, 2017-06-14 18:29:05]

lgtm

https://codereview.chromium.org/2938823002/diff/1/pkg/compiler/lib/src/native...
File pkg/compiler/lib/src/native/behavior.dart (right):

https://codereview.chromium.org/2938823002/diff/1/pkg/compiler/lib/src/native...
pkg/compiler/lib/src/native/behavior.dart:526: dynamic specArgument =
argNodes.head;
On 2017/06/14 18:27:23, ahe wrote:
> On 2017/06/14 17:42:51, Emily Fortuna wrote:
> > this should be type Node
> 
> That's what's inferred, but that type is not compatible with the assumption
that
> specArgument is a StringNode below.
> 
> What I'm trying to do here is go quickly through dart2js and make as small
> changes as possible, and I think using dynamic is the safest way to that.
> Someone can do another pass to remove dynamic, but consider that this code is
> going to be replaced by the shared front-end.

got it. thanks

[ahe, 2017-06-14 18:34:13]

Description was changed from

==========
Start making dart2js strong mode clean.
==========

to

==========
Start making dart2js strong mode clean.

R=efortuna@google.com

Committed:
https://github.com/dart-lang/sdk/commit/87700d381c53e533b038e51f3072d2fed5f5ac59
==========

[ahe, 2017-06-14 18:34:14]

Committed patchset #2 (id:20001) manually as
87700d381c53e533b038e51f3072d2fed5f5ac59 (presubmit successful).