Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2941713002: NetInfo: Return HTTP layer metrics instead of transport layer (Closed)

Created:
3 years, 6 months ago by tbansal1
Modified:
3 years, 6 months ago
CC:
chromium-reviews, jam, blink-reviews, darin-cc_chromium.org, jkarlin+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

NetInfo: Return HTTP layer metrics instead of transport layer BUG=733881 Review-Url: https://codereview.chromium.org/2941713002 Cr-Commit-Position: refs/heads/master@{#480319} Committed: https://chromium.googlesource.com/chromium/src/+/75451111c9feeebc1a8b4d7a9a407013ca981fb5

Patch Set 1 : ps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -32 lines) Patch
M content/browser/net_info_browsertest.cc View 5 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/modules/netinfo/NetworkInformation.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp View 4 chunks +8 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/network/NetworkStateNotifier.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/network/NetworkStateNotifierTest.cpp View 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 58 (50 generated)
tbansal1
jkarlin: ptal at *. Thanks
3 years, 6 months ago (2017-06-16 15:33:34 UTC) #34
tbansal1
jkarlin: ptal at *. Thanks.
3 years, 6 months ago (2017-06-16 15:33:58 UTC) #36
jkarlin
lgtm!
3 years, 6 months ago (2017-06-16 16:48:25 UTC) #43
tbansal1
ptal: haraken: third_party/WebKit/Source/platform/network/* creis: content/browser/net_info_browsertest.cc Thanks.
3 years, 6 months ago (2017-06-16 16:49:38 UTC) #45
haraken
WebKit LGTM
3 years, 6 months ago (2017-06-17 01:37:56 UTC) #48
Charlie Reis
content/ LGTM
3 years, 6 months ago (2017-06-17 20:11:31 UTC) #49
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2941713002/100001
3 years, 6 months ago (2017-06-18 18:22:13 UTC) #55
commit-bot: I haz the power
3 years, 6 months ago (2017-06-18 23:27:56 UTC) #58
Message was sent while issue was closed.
Committed patchset #1 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/75451111c9feeebc1a8b4d7a9a40...

Powered by Google App Engine
This is Rietveld 408576698