third_party/WebKit/Source/platform/network/NetworkStateNotifier.cpp - Issue 2941713002: NetInfo: Return HTTP layer metrics instead of transport layer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/network/NetworkStateNotifier.cpp

Issue 2941713002: NetInfo: Return HTTP layer metrics instead of transport layer (Closed)

Patch Set: ps Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp ('k') | third_party/WebKit/Source/platform/network/NetworkStateNotifierTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/network/NetworkStateNotifier.cpp

diff --git a/third_party/WebKit/Source/platform/network/NetworkStateNotifier.cpp b/third_party/WebKit/Source/platform/network/NetworkStateNotifier.cpp

index baf8c9e805fd21b4be012e0f8e2a20ed42e934ce..c56e36a45229935f16d85f96a7cfccbef01c1c11 100644

--- a/third_party/WebKit/Source/platform/network/NetworkStateNotifier.cpp

+++ b/third_party/WebKit/Source/platform/network/NetworkStateNotifier.cpp

@@ -175,8 +175,7 @@ void NetworkStateNotifier::SetNetworkQualityInfoOverride(

override_.on_line_initialized = true;

override_.connection_initialized = true;

override_.effective_type = effective_type;

- override_.transport_rtt =

- base::TimeDelta::FromMilliseconds(transport_rtt_msec);

+ override_.http_rtt = base::TimeDelta::FromMilliseconds(transport_rtt_msec);

override_.downlink_throughput_mbps = base::nullopt;

if (downlink_throughput_mbps >= 0)

override_.downlink_throughput_mbps = downlink_throughput_mbps;