Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Unified Diff: third_party/WebKit/Source/platform/network/NetworkStateNotifierTest.cpp

Issue 2941713002: NetInfo: Return HTTP layer metrics instead of transport layer (Closed)
Patch Set: ps Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/network/NetworkStateNotifier.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/network/NetworkStateNotifierTest.cpp
diff --git a/third_party/WebKit/Source/platform/network/NetworkStateNotifierTest.cpp b/third_party/WebKit/Source/platform/network/NetworkStateNotifierTest.cpp
index 1797c844a56d3eb0bc2b7657ed5b5748e581e31b..6a1e1075f202be453806577b185b46a8bfa3ccef 100644
--- a/third_party/WebKit/Source/platform/network/NetworkStateNotifierTest.cpp
+++ b/third_party/WebKit/Source/platform/network/NetworkStateNotifierTest.cpp
@@ -585,19 +585,19 @@ TEST_F(NetworkStateNotifierTest, SetNetworkQualityInfoOverride) {
notifier_.SetNetworkQualityInfoOverride(
WebEffectiveConnectionType::kType3G,
- kEthernetTransportRtt.value().InMilliseconds(),
+ kEthernetHttpRtt.value().InMilliseconds(),
kEthernetThroughputMbps.value());
RunPendingTasks();
EXPECT_TRUE(VerifyObservations(
observer, kWebConnectionTypeOther,
NetworkStateNotifier::NetworkState::kInvalidMaxBandwidth,
- WebEffectiveConnectionType::kType3G, kUnknownRtt, kEthernetTransportRtt,
+ WebEffectiveConnectionType::kType3G, kEthernetHttpRtt, kUnknownRtt,
kEthernetThroughputMbps));
EXPECT_TRUE(notifier_.OnLine());
EXPECT_EQ(kWebConnectionTypeOther, notifier_.ConnectionType());
EXPECT_EQ(-1, notifier_.MaxBandwidth());
EXPECT_EQ(WebEffectiveConnectionType::kType3G, notifier_.EffectiveType());
- EXPECT_EQ(kEthernetTransportRtt, notifier_.TransportRtt());
+ EXPECT_EQ(kEthernetHttpRtt, notifier_.HttpRtt());
EXPECT_EQ(kEthernetThroughputMbps, notifier_.DownlinkThroughputMbps());
// When override is active, calls to SetConnection are temporary ignored.
@@ -609,13 +609,13 @@ TEST_F(NetworkStateNotifierTest, SetNetworkQualityInfoOverride) {
EXPECT_TRUE(VerifyObservations(
observer, kWebConnectionTypeOther,
NetworkStateNotifier::NetworkState::kInvalidMaxBandwidth,
- WebEffectiveConnectionType::kType3G, kUnknownRtt, kEthernetTransportRtt,
+ WebEffectiveConnectionType::kType3G, kEthernetHttpRtt, kUnknownRtt,
kEthernetThroughputMbps));
EXPECT_TRUE(notifier_.OnLine());
EXPECT_EQ(kWebConnectionTypeOther, notifier_.ConnectionType());
EXPECT_EQ(-1, notifier_.MaxBandwidth());
EXPECT_EQ(WebEffectiveConnectionType::kType3G, notifier_.EffectiveType());
- EXPECT_EQ(kEthernetTransportRtt, notifier_.TransportRtt());
+ EXPECT_EQ(kEthernetHttpRtt, notifier_.HttpRtt());
EXPECT_EQ(kEthernetThroughputMbps, notifier_.DownlinkThroughputMbps());
// Override the network connection info as well.
@@ -624,13 +624,13 @@ TEST_F(NetworkStateNotifierTest, SetNetworkQualityInfoOverride) {
RunPendingTasks();
EXPECT_TRUE(VerifyObservations(
observer, kWebConnectionTypeEthernet, kEthernetMaxBandwidthMbps,
- WebEffectiveConnectionType::kType3G, kUnknownRtt, kEthernetTransportRtt,
+ WebEffectiveConnectionType::kType3G, kEthernetHttpRtt, kUnknownRtt,
kEthernetThroughputMbps));
EXPECT_TRUE(notifier_.OnLine());
EXPECT_EQ(kWebConnectionTypeEthernet, notifier_.ConnectionType());
EXPECT_EQ(kEthernetMaxBandwidthMbps, notifier_.MaxBandwidth());
EXPECT_EQ(WebEffectiveConnectionType::kType3G, notifier_.EffectiveType());
- EXPECT_EQ(kEthernetTransportRtt, notifier_.TransportRtt());
+ EXPECT_EQ(kEthernetHttpRtt, notifier_.HttpRtt());
EXPECT_EQ(kEthernetThroughputMbps, notifier_.DownlinkThroughputMbps());
// CLearing the override should cause the network state to be changed and
« no previous file with comments | « third_party/WebKit/Source/platform/network/NetworkStateNotifier.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698