Break StyleImage dependency on LayoutObject

Break StyleImage dependency on LayoutObject

Break the dependency on LayoutObject by StyleImage by explicitly passing
the required parameters rather than getting them from a LayoutObject and
by using the ImageResourceObserver interface to keep track of observers.

Part of a larger set of changes to break dependencies on LayoutObject in
order to allow improved code sharing between legacy layout and LayoutNG.

BUG=714962
R=pdr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2941533002
Cr-Commit-Position: refs/heads/master@{#479144}
Committed: https://chromium.googlesource.com/chromium/src/+/5609ccb5f5426a991ce70426525bf9c0959990e4

[eae, 2017-06-13 15:59:22]

Description was changed from

==========
Break StyleImage dependency on LayoutObject

Break the dependency on LayoutObject by StyleImage by explicitly passing
the required parameters rather than getting them from a LayoutObject and
by using the ImageResourceObserver interface to keep track of observers.

Part of a larger set of changes to break dependencies on LayoutObject in
order to allow improved code sharing between legacy layout and LayoutNG.

BUG=714962
R=pdr@chromium.org
==========

to

==========
Break StyleImage dependency on LayoutObject

Break the dependency on LayoutObject by StyleImage by explicitly passing
the required parameters rather than getting them from a LayoutObject and
by using the ImageResourceObserver interface to keep track of observers.

Part of a larger set of changes to break dependencies on LayoutObject in
order to allow improved code sharing between legacy layout and LayoutNG.

BUG=714962
R=pdr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[eae, 2017-06-13 15:59:26]

The CQ bit was checked by eae@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 16:00:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 16:13:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 16:13:15]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[eae, 2017-06-13 16:34:31]

The CQ bit was checked by eae@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 16:34:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 17:00:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 17:00:01]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[pdr., 2017-06-13 17:55:57]

LGTM but this seems to be failing on the bots.

[eae, 2017-06-13 18:09:05]

eae@chromium.org changed reviewers:
+ ikilpatrick@chromium.org

[eae, 2017-06-13 18:09:10]

The CQ bit was checked by eae@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 18:09:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ikilpatrick, 2017-06-13 18:41:01]

lgtm

https://codereview.chromium.org/2941533002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSGradientValue.cpp (right):

https://codereview.chromium.org/2941533002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSGradientValue.cpp:132: &style, root_style,
LayoutViewItem(layout_object.View()),
LayoutViewItem(document.View());

https://codereview.chromium.org/2941533002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutObject.h (right):

https://codereview.chromium.org/2941533002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutObject.h:1552: void
ImageChanged(WrappedImagePtr, const IntRect* = nullptr) override {}
move up to other ImageChanged override.

https://codereview.chromium.org/2941533002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.cpp (right):

https://codereview.chromium.org/2941533002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.cpp:76: // TODO:
Break dependency on LayoutObject.
todo: add node.

[eae, 2017-06-13 18:48:07]

Thanks, CSSGradientView needs the LayoutObject for CreateGradient as well. I'll
try to untangle that in a follow up change.

[eae, 2017-06-13 18:48:11]

The CQ bit was checked by eae@chromium.org

[eae, 2017-06-13 18:48:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
ikilpatrick@chromium.org, pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2941533002/#ps40001
(title: "Address reviewer comments")

[commit-bot: I haz the power, 2017-06-13 18:48:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 20:56:40]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497379691013810,
"parent_rev": "99913d0de1ae13773c571a77445571c8fbd2215f", "commit_rev":
"5609ccb5f5426a991ce70426525bf9c0959990e4"}

[commit-bot: I haz the power, 2017-06-13 20:56:53]

Description was changed from

==========
Break StyleImage dependency on LayoutObject

Break the dependency on LayoutObject by StyleImage by explicitly passing
the required parameters rather than getting them from a LayoutObject and
by using the ImageResourceObserver interface to keep track of observers.

Part of a larger set of changes to break dependencies on LayoutObject in
order to allow improved code sharing between legacy layout and LayoutNG.

BUG=714962
R=pdr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Break StyleImage dependency on LayoutObject

Break the dependency on LayoutObject by StyleImage by explicitly passing
the required parameters rather than getting them from a LayoutObject and
by using the ImageResourceObserver interface to keep track of observers.

Part of a larger set of changes to break dependencies on LayoutObject in
order to allow improved code sharing between legacy layout and LayoutNG.

BUG=714962
R=pdr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2941533002
Cr-Commit-Position: refs/heads/master@{#479144}
Committed:
https://chromium.googlesource.com/chromium/src/+/5609ccb5f5426a991ce70426525b...
==========

[commit-bot: I haz the power, 2017-06-13 20:56:55]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5609ccb5f5426a991ce70426525b...