third_party/WebKit/Source/modules/csspaint/CSSPaintImageGeneratorImpl.h - Issue 2941533002: Break StyleImage dependency on LayoutObject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/csspaint/CSSPaintImageGeneratorImpl.h

Issue 2941533002: Break StyleImage dependency on LayoutObject (Closed)

Patch Set: Address reviewer comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.cpp ('k') | third_party/WebKit/Source/modules/csspaint/CSSPaintImageGeneratorImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/csspaint/CSSPaintImageGeneratorImpl.h

diff --git a/third_party/WebKit/Source/modules/csspaint/CSSPaintImageGeneratorImpl.h b/third_party/WebKit/Source/modules/csspaint/CSSPaintImageGeneratorImpl.h

index 6b4d5ea2b90878560b1b0163e2cce6bc4e3404cb..5b383bd66c8bef241649ff7a69b23d33db8726e9 100644

--- a/third_party/WebKit/Source/modules/csspaint/CSSPaintImageGeneratorImpl.h

+++ b/third_party/WebKit/Source/modules/csspaint/CSSPaintImageGeneratorImpl.h

@@ -22,11 +22,11 @@ class Image;

class CSSPaintImageGeneratorImpl final : public CSSPaintImageGenerator {

public:

static CSSPaintImageGenerator* Create(const String& name,

- Document&,

+ const Document&,

Observer*);

~CSSPaintImageGeneratorImpl() override;

- PassRefPtr<Image> Paint(const LayoutObject&,

+ PassRefPtr<Image> Paint(const ImageResourceObserver&,

const IntSize&,

const CSSStyleValueVector*) final;

const Vector<CSSPropertyID>& NativeInvalidationProperties() const final;