Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Side by Side Diff: third_party/WebKit/Source/core/loader/resource/ImageResourceObserver.h

Issue 2941533002: Break StyleImage dependency on LayoutObject (Closed)
Patch Set: Address reviewer comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de) 2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
3 Copyright (C) 2001 Dirk Mueller <mueller@kde.org> 3 Copyright (C) 2001 Dirk Mueller <mueller@kde.org>
4 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com) 4 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
5 Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 5 Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
6 6
7 This library is free software; you can redistribute it and/or 7 This library is free software; you can redistribute it and/or
8 modify it under the terms of the GNU Library General Public 8 modify it under the terms of the GNU Library General Public
9 License as published by the Free Software Foundation; either 9 License as published by the Free Software Foundation; either
10 version 2 of the License, or (at your option) any later version. 10 version 2 of the License, or (at your option) any later version.
11 11
12 This library is distributed in the hope that it will be useful, 12 This library is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of 13 but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
15 Library General Public License for more details. 15 Library General Public License for more details.
16 16
17 You should have received a copy of the GNU Library General Public License 17 You should have received a copy of the GNU Library General Public License
18 along with this library; see the file COPYING.LIB. If not, write to 18 along with this library; see the file COPYING.LIB. If not, write to
19 the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 19 the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
20 Boston, MA 02110-1301, USA. 20 Boston, MA 02110-1301, USA.
21 */ 21 */
22 22
23 #ifndef ImageResourceObserver_h 23 #ifndef ImageResourceObserver_h
24 #define ImageResourceObserver_h 24 #define ImageResourceObserver_h
25 25
26 #include "core/CoreExport.h" 26 #include "core/CoreExport.h"
27 #include "core/style/StyleImage.h"
27 #include "platform/graphics/ImageAnimationPolicy.h" 28 #include "platform/graphics/ImageAnimationPolicy.h"
28 #include "platform/loader/fetch/ResourceLoadPriority.h" 29 #include "platform/loader/fetch/ResourceLoadPriority.h"
29 #include "platform/wtf/Forward.h" 30 #include "platform/wtf/Forward.h"
30 31
31 namespace blink { 32 namespace blink {
32 33
33 class ImageResourceContent; 34 class ImageResourceContent;
34 class IntRect; 35 class IntRect;
35 36
36 class CORE_EXPORT ImageResourceObserver { 37 class CORE_EXPORT ImageResourceObserver {
37 public: 38 public:
38 virtual ~ImageResourceObserver() {} 39 virtual ~ImageResourceObserver() {}
39 40
40 // Called whenever a frame of an image changes, either because we got more 41 // Called whenever a frame of an image changes, either because we got more
41 // data from the network or because we are animating. If not null, the IntRect 42 // data from the network or because we are animating. If not null, the IntRect
42 // is the changed rect of the image. 43 // is the changed rect of the image.
43 virtual void ImageChanged(ImageResourceContent*, const IntRect* = 0) {} 44 virtual void ImageChanged(ImageResourceContent*, const IntRect* = nullptr) {}
45
46 // Sub-classes that have an associated image need to override this function
47 // to get notified of any image change.
48 virtual void ImageChanged(WrappedImagePtr, const IntRect* = nullptr) {}
44 49
45 // Called just after imageChanged() if all image data is received or errored. 50 // Called just after imageChanged() if all image data is received or errored.
46 // TODO(hiroshige): Merge imageNotifyFinished() into imageChanged(). 51 // TODO(hiroshige): Merge imageNotifyFinished() into imageChanged().
47 virtual void ImageNotifyFinished(ImageResourceContent*) {} 52 virtual void ImageNotifyFinished(ImageResourceContent*) {}
48 53
49 // Called to find out if this client wants to actually display the image. Used 54 // Called to find out if this client wants to actually display the image. Used
50 // to tell when we can halt animation. Content nodes that hold image refs for 55 // to tell when we can halt animation. Content nodes that hold image refs for
51 // example would not render the image, but LayoutImages would (assuming they 56 // example would not render the image, but LayoutImages would (assuming they
52 // have visibility: visible and their layout tree isn't hidden e.g., in the 57 // have visibility: visible and their layout tree isn't hidden e.g., in the
53 // b/f cache or in a background tab). 58 // b/f cache or in a background tab).
(...skipping 14 matching lines...) Expand all
68 73
69 // Name for debugging, e.g. shown in memory-infra. 74 // Name for debugging, e.g. shown in memory-infra.
70 virtual String DebugName() const = 0; 75 virtual String DebugName() const = 0;
71 76
72 static bool IsExpectedType(ImageResourceObserver*) { return true; } 77 static bool IsExpectedType(ImageResourceObserver*) { return true; }
73 }; 78 };
74 79
75 } // namespace blink 80 } // namespace blink
76 81
77 #endif 82 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.cpp ('k') | third_party/WebKit/Source/core/paint/BoxPainter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698