Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2941423002: viz: Move ServerGpuMemoryBufferManager into host/gpu. (Closed)

Created:
3 years, 6 months ago by sadrul
Modified:
3 years, 5 months ago
Reviewers:
danakj, Fady Samuel, sky
CC:
chromium-reviews, rjkroege, darin (slow to review), qsr+mojo_chromium.org, droger+watchlist_chromium.org, vmpstr+watch_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, piman+watch_chromium.org, danakj+watch_chromium.org, cc-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

viz: Move ServerGpuMemoryBufferManager into host/gpu. ServerGpuMemoryBufferManager used to live in viz/common, because it was used by both the gpu host, and the display compositor service. Now that the latter uses InProcessGpuMemoryBufferManager, ServerGpuMemoryBufferManager can move into its rightful place. BUG=733482 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2941423002 Cr-Commit-Position: refs/heads/master@{#482669} Committed: https://chromium.googlesource.com/chromium/src/+/20c537c4f7982d52ba84cbbef7de7f48380dbd17

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : tot merge #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : fix tot merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -544 lines) Patch
M components/BUILD.gn View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
D components/viz/common/BUILD.gn View 1 2 3 4 1 chunk +0 lines, -36 lines 0 comments Download
D components/viz/common/DEPS View 1 2 3 4 5 6 1 chunk +0 lines, -9 lines 0 comments Download
D components/viz/common/server_gpu_memory_buffer_manager.h View 1 2 3 4 1 chunk +0 lines, -84 lines 0 comments Download
D components/viz/common/server_gpu_memory_buffer_manager.cc View 1 2 3 4 5 6 1 chunk +0 lines, -144 lines 0 comments Download
D components/viz/common/server_gpu_memory_buffer_manager_unittest.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -258 lines 0 comments Download
M components/viz/host/BUILD.gn View 1 2 3 4 5 6 7 3 chunks +14 lines, -1 line 0 comments Download
M components/viz/host/DEPS View 1 2 3 4 5 6 1 chunk +7 lines, -0 lines 0 comments Download
A + components/viz/host/server_gpu_memory_buffer_manager.h View 1 2 3 4 5 6 5 chunks +7 lines, -5 lines 0 comments Download
A + components/viz/host/server_gpu_memory_buffer_manager.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
A + components/viz/host/server_gpu_memory_buffer_manager_unittest.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/BUILD.gn View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/DEPS View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/gpu_client.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/gpu_host.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 50 (41 generated)
sadrul
3 years, 6 months ago (2017-06-21 18:52:03 UTC) #22
danakj
What goes in host/gpu/ vs in host/ ?
3 years, 6 months ago (2017-06-21 18:53:42 UTC) #23
sadrul
+fsamuel@ On 2017/06/21 18:53:42, danakj wrote: > What goes in host/gpu/ vs in host/ ? ...
3 years, 6 months ago (2017-06-21 18:56:39 UTC) #25
danakj
On 2017/06/21 18:56:39, sadrul wrote: > +fsamuel@ > > On 2017/06/21 18:53:42, danakj wrote: > ...
3 years, 6 months ago (2017-06-21 21:51:32 UTC) #28
danakj
So.. LGTM to put in c/viz/host. I would suggest not the gpu subdir for now.
3 years, 6 months ago (2017-06-21 21:52:24 UTC) #29
sadrul
+sky@ for components/BUILD.gn, and services/ui/ws/ On 2017/06/21 21:52:24, danakj wrote: > So.. LGTM to put ...
3 years, 5 months ago (2017-06-26 22:36:39 UTC) #33
sky
LGTM
3 years, 5 months ago (2017-06-27 02:08:16 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2941423002/160001
3 years, 5 months ago (2017-06-27 17:36:19 UTC) #47
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 17:40:21 UTC) #50
Message was sent while issue was closed.
Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/20c537c4f7982d52ba84cbbef7de...

Powered by Google App Engine
This is Rietveld 408576698