Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2941413002: PDF: Consistently pass FPDF handles by value. (Closed)

Created:
3 years, 6 months ago by Lei Zhang
Modified:
3 years, 6 months ago
Reviewers:
dsinclair
CC:
chromium-reviews, fuzzing_chromium.org, drgage
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

PDF: Consistently pass FPDF handles by value. They are all void* underneath anyway. Review-Url: https://codereview.chromium.org/2941413002 Cr-Commit-Position: refs/heads/master@{#481197} Committed: https://chromium.googlesource.com/chromium/src/+/4b156d5d593feef2776c2d08bf98b3674829fff4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M pdf/pdfium/fuzzers/pdfium_fuzzer_helper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M pdf/pdfium/fuzzers/pdfium_fuzzer_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M pdf/pdfium/pdfium_engine.h View 1 chunk +2 lines, -2 lines 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Lei Zhang
More of the same.
3 years, 6 months ago (2017-06-17 02:22:25 UTC) #4
dsinclair
lgtm
3 years, 6 months ago (2017-06-21 12:58:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2941413002/1
3 years, 6 months ago (2017-06-21 12:58:14 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-21 14:11:45 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4b156d5d593feef2776c2d08bf98...

Powered by Google App Engine
This is Rietveld 408576698