Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: pdf/pdfium/pdfium_engine.cc

Issue 2941413002: PDF: Consistently pass FPDF handles by value. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pdf/pdfium/pdfium_engine.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pdf/pdfium/pdfium_engine.cc
diff --git a/pdf/pdfium/pdfium_engine.cc b/pdf/pdfium/pdfium_engine.cc
index afc8b71633bcd2bbab24880da6b033316bfe63a9..b6fdb615511da0d75b2552e8a00b7ea14540c582 100644
--- a/pdf/pdfium/pdfium_engine.cc
+++ b/pdf/pdfium/pdfium_engine.cc
@@ -1529,7 +1529,7 @@ pp::Buffer_Dev PDFiumEngine::PrintPagesAsRasterPDF(
return buffer;
}
-pp::Buffer_Dev PDFiumEngine::GetFlattenedPrintData(const FPDF_DOCUMENT& doc) {
+pp::Buffer_Dev PDFiumEngine::GetFlattenedPrintData(FPDF_DOCUMENT doc) {
pp::Buffer_Dev buffer;
ScopedSubstFont scoped_subst_font(this);
int page_count = FPDF_GetPageCount(doc);
@@ -1605,7 +1605,7 @@ pp::Buffer_Dev PDFiumEngine::PrintPagesAsPDF(
}
void PDFiumEngine::FitContentsToPrintableAreaIfRequired(
- const FPDF_DOCUMENT& doc,
+ FPDF_DOCUMENT doc,
const PP_PrintSettings_Dev& print_settings) {
// Check to see if we need to fit pdf contents to printer paper size.
if (print_settings.print_scaling_option !=
« no previous file with comments | « pdf/pdfium/pdfium_engine.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698