PDF: Consistently pass FPDF handles by value.

pdf/pdfium/pdfium_engine.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "pdf/pdfium/pdfium_engine.h"
 
 #include <math.h>
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 1511 matching lines @@
   if (i == pages_to_print.size()) {
     FPDF_CopyViewerPreferences(output_doc, doc_);
     FitContentsToPrintableAreaIfRequired(output_doc, print_settings);
     // Now flatten all the output pages.
     buffer = GetFlattenedPrintData(output_doc);
   }
   FPDF_CloseDocument(output_doc);
   return buffer;
 }
 
-pp::Buffer_Dev PDFiumEngine::GetFlattenedPrintData(const FPDF_DOCUMENT& doc) {
+pp::Buffer_Dev PDFiumEngine::GetFlattenedPrintData(FPDF_DOCUMENT doc) {
   pp::Buffer_Dev buffer;
   ScopedSubstFont scoped_subst_font(this);
   int page_count = FPDF_GetPageCount(doc);
   for (int i = 0; i < page_count; ++i) {
     FPDF_PAGE page = FPDF_LoadPage(doc, i);
     DCHECK(page);
     int flatten_ret = FPDFPage_Flatten(page, FLAT_PRINT);
     FPDF_ClosePage(page);
     if (flatten_ret == FLATTEN_FAIL)
       return buffer;
@@ skipping 55 matching lines @@
 
   FitContentsToPrintableAreaIfRequired(output_doc, print_settings);
 
   // Now flatten all the output pages.
   pp::Buffer_Dev buffer = GetFlattenedPrintData(output_doc);
   FPDF_CloseDocument(output_doc);
   return buffer;
 }
 
 void PDFiumEngine::FitContentsToPrintableAreaIfRequired(
-    const FPDF_DOCUMENT& doc,
+    FPDF_DOCUMENT doc,
     const PP_PrintSettings_Dev& print_settings) {
   // Check to see if we need to fit pdf contents to printer paper size.
   if (print_settings.print_scaling_option !=
       PP_PRINTSCALINGOPTION_SOURCE_SIZE) {
     int num_pages = FPDF_GetPageCount(doc);
     // In-place transformation is more efficient than creating a new
     // transformed document from the source document. Therefore, transform
     // every page to fit the contents in the selected printer paper.
     for (int i = 0; i < num_pages; ++i) {
       FPDF_PAGE page = FPDF_LoadPage(doc, i);
@@ skipping 2516 matching lines @@
   FPDF_DOCUMENT doc =
       FPDF_LoadMemDocument(pdf_buffer, pdf_buffer_size, nullptr);
   if (!doc)
     return false;
   bool success = FPDF_GetPageSizeByIndex(doc, page_number, width, height) != 0;
   FPDF_CloseDocument(doc);
   return success;
 }
 
 }  // namespace chrome_pdf