Finish strong mode cleaning of dart2js.

Finish strong mode cleaning of dart2js.

R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/0750bc20edd8daa8a54d20d19e5d0be317ccf94e

[ahe, 2017-06-15 09:36:38]

ahe@google.com changed reviewers:
+ efortuna@google.com, johnniwinther@google.com

[ahe, 2017-06-15 09:36:39]

There's a few comments below that I could use your help with.

But package:compiler is not strong mode clean.

dart2js unit tests still not strong mode clean.

https://codereview.chromium.org/2941033002/diff/1/pkg/compiler/lib/src/inferr...
File pkg/compiler/lib/src/inferrer/locals_handler.dart (right):

https://codereview.chromium.org/2941033002/diff/1/pkg/compiler/lib/src/inferr...
pkg/compiler/lib/src/inferrer/locals_handler.dart:194: // TODO(ahe): This is a
bug.
I'll file an issue about this and update the comment.

https://codereview.chromium.org/2941033002/diff/1/pkg/compiler/lib/src/inferr...
File pkg/compiler/lib/src/inferrer/node_tracer.dart (right):

https://codereview.chromium.org/2941033002/diff/1/pkg/compiler/lib/src/inferr...
pkg/compiler/lib/src/inferrer/node_tracer.dart:395: // TODO(ahe): Is this a bug?
I'll file a bug and update the comment.

https://codereview.chromium.org/2941033002/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/full_emitter/class_builder.dart (right):

https://codereview.chromium.org/2941033002/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/full_emitter/class_builder.dart:21:
List<jsAst.Expression> fieldMetadata;
I'm concerned about causing a checked mode problem.

https://codereview.chromium.org/2941033002/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/no_such_method_resolver.dart (right):

https://codereview.chromium.org/2941033002/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/no_such_method_resolver.dart:55: // ignore:
UNDEFINED_GETTER
Type of arg is *known* to be Send due to is test, so arg.selection has a known
type that has no source argument. I don't know how to fix this.

[Johnni Winther, 2017-06-15 09:51:07]

LGTM (as a toll to Charon)

[Johnni Winther, 2017-06-15 10:21:26]

https://codereview.chromium.org/2941033002/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/full_emitter/class_builder.dart (right):

https://codereview.chromium.org/2941033002/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/full_emitter/class_builder.dart:21:
List<jsAst.Expression> fieldMetadata;
On 2017/06/15 09:36:39, ahe wrote:
> I'm concerned about causing a checked mode problem.

If you change `var fieldMetadata = [];` in class_emitter line 128 to ` var
fieldMetadata = <Expression>[];` it should be fine.

https://codereview.chromium.org/2941033002/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/no_such_method_resolver.dart (right):

https://codereview.chromium.org/2941033002/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/no_such_method_resolver.dart:55: // ignore:
UNDEFINED_GETTER
On 2017/06/15 09:36:39, ahe wrote:
> Type of arg is *known* to be Send due to is test, so arg.selection has a known
> type that has no source argument. I don't know how to fix this.

We probably need to nest ifs to make 'arg.selector' a local.

[ahe, 2017-06-15 11:41:57]

Thank you, Johnni. That's a nice obol you got there.

https://codereview.chromium.org/2941033002/diff/1/pkg/compiler/lib/src/inferr...
File pkg/compiler/lib/src/inferrer/locals_handler.dart (right):

https://codereview.chromium.org/2941033002/diff/1/pkg/compiler/lib/src/inferr...
pkg/compiler/lib/src/inferrer/locals_handler.dart:194: // TODO(ahe): This is a
bug.
On 2017/06/15 09:36:39, ahe wrote:
> I'll file an issue about this and update the comment.

Done.

https://codereview.chromium.org/2941033002/diff/1/pkg/compiler/lib/src/inferr...
File pkg/compiler/lib/src/inferrer/node_tracer.dart (right):

https://codereview.chromium.org/2941033002/diff/1/pkg/compiler/lib/src/inferr...
pkg/compiler/lib/src/inferrer/node_tracer.dart:395: // TODO(ahe): Is this a bug?
On 2017/06/15 09:36:39, ahe wrote:
> I'll file a bug and update the comment.

Done.

https://codereview.chromium.org/2941033002/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/full_emitter/class_builder.dart (right):

https://codereview.chromium.org/2941033002/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/full_emitter/class_builder.dart:21:
List<jsAst.Expression> fieldMetadata;
On 2017/06/15 10:21:26, Johnni Winther wrote:
> On 2017/06/15 09:36:39, ahe wrote:
> > I'm concerned about causing a checked mode problem.
> 
> If you change `var fieldMetadata = [];` in class_emitter line 128 to ` var
> fieldMetadata = <Expression>[];` it should be fine.

Done.

https://codereview.chromium.org/2941033002/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/no_such_method_resolver.dart (right):

https://codereview.chromium.org/2941033002/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/no_such_method_resolver.dart:55: // ignore:
UNDEFINED_GETTER
On 2017/06/15 10:21:26, Johnni Winther wrote:
> On 2017/06/15 09:36:39, ahe wrote:
> > Type of arg is *known* to be Send due to is test, so arg.selection has a
known
> > type that has no source argument. I don't know how to fix this.
> 
> We probably need to nest ifs to make 'arg.selector' a local.

Done.

[ahe, 2017-06-15 11:49:09]

Description was changed from

==========
Finish strong mode cleaning of dart2js.
==========

to

==========
Finish strong mode cleaning of dart2js.

R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0750bc20edd8daa8a54d20d19e5d0be317ccf94e
==========

[ahe, 2017-06-15 11:49:10]

Committed patchset #2 (id:20001) manually as
0750bc20edd8daa8a54d20d19e5d0be317ccf94e (presubmit successful).