pkg/compiler/lib/src/types/dictionary_type_mask.dart - Issue 2941033002: Finish strong mode cleaning of dart2js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/types/dictionary_type_mask.dart

Issue 2941033002: Finish strong mode cleaning of dart2js. (Closed)

Patch Set: Add bug numbers and address comments. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/types/dictionary_type_mask.dart

diff --git a/pkg/compiler/lib/src/types/dictionary_type_mask.dart b/pkg/compiler/lib/src/types/dictionary_type_mask.dart

index fc7a8a593f0bb778e91194e8f832649934f9d153..0c4bd8090dcd8f5aff4751a85922a5f576228b93 100644

--- a/pkg/compiler/lib/src/types/dictionary_type_mask.dart

+++ b/pkg/compiler/lib/src/types/dictionary_type_mask.dart

@@ -53,7 +53,7 @@ class DictionaryTypeMask extends MapTypeMask {

return forwardIntersection.isNullable ? nullable() : nonNullable();

}

- TypeMask union(other, ClosedWorld closedWorld) {

+ TypeMask union(dynamic other, ClosedWorld closedWorld) {

if (this == other) {

return this;

} else if (equalsDisregardNull(other)) {