pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart - Issue 2941033002: Finish strong mode cleaning of dart2js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart

Issue 2941033002: Finish strong mode cleaning of dart2js. (Closed)

Patch Set: Add bug numbers and address comments. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart ('k') | pkg/compiler/lib/src/js_emitter/type_test_registry.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart

diff --git a/pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart b/pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart

index d5a7f0eede37890ff127ab5a451aea9b1cd20c58..822dddff63d07d23ea5b8b6f6c97f74ded8d5036 100644

--- a/pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart

+++ b/pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart

@@ -1168,7 +1168,7 @@ class FragmentEmitter {

}

for (Class cls in library.classes) {

if (cls.isSoftDeferred != softDeferred) continue;

- var methods = cls.methods.where((m) => m.needsTearOff).toList();

+ var methods = cls.methods.where((dynamic m) => m.needsTearOff).toList();

js.Expression container = js.js("#.prototype", classReference(cls));

js.Expression reference = container;

if (methods.length > 1) {