Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: pkg/compiler/lib/src/universe/function_set.dart

Issue 2941033002: Finish strong mode cleaning of dart2js. (Closed)
Patch Set: Add bug numbers and address comments. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/universe/element_world_builder.dart ('k') | pkg/compiler/testing_strong.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/universe/function_set.dart
diff --git a/pkg/compiler/lib/src/universe/function_set.dart b/pkg/compiler/lib/src/universe/function_set.dart
index ca18c1fb4a57d445eb1d68b53c62587a6cc9c0a6..2260ed88e391809d7fbb836a9e2b7d074992234d 100644
--- a/pkg/compiler/lib/src/universe/function_set.dart
+++ b/pkg/compiler/lib/src/universe/function_set.dart
@@ -178,10 +178,10 @@ class FunctionSetNode {
isList = false;
}
if (isList) {
- List list = elements;
+ List<MemberEntity> list = elements;
list.add(element);
} else {
- Set set = elements;
+ Set<MemberEntity> set = elements;
set.add(element);
}
if (!cache.isEmpty) cache.clear();
@@ -191,7 +191,7 @@ class FunctionSetNode {
void remove(MemberEntity element) {
assert(element.name == name);
if (isList) {
- List list = elements;
+ List<MemberEntity> list = elements;
int index = list.indexOf(element);
if (index < 0) return;
MemberEntity last = list.removeLast();
@@ -200,7 +200,7 @@ class FunctionSetNode {
}
if (!cache.isEmpty) cache.clear();
} else {
- Set set = elements;
+ Set<MemberEntity> set = elements;
if (set.remove(element)) {
// To avoid wobbling between the two representations, we do
// not transition back to the list representation even if we
« no previous file with comments | « pkg/compiler/lib/src/universe/element_world_builder.dart ('k') | pkg/compiler/testing_strong.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698