Hook up persist toggle UMA for PermissionRequestManager on Android

Hook up persist toggle UMA for PermissionRequestManager on Android

This patch wires up UMA for the persist toggle, for when the
PermissionRequestManager is enabled on Android, as the current
implementation is in the PermissionInfoBarDelegate. Both InfoBars and
Dialogs will record UMA as they both delegate to the PermissionPrompt.

BUG=606138
Review-Url: https://codereview.chromium.org/2941013002
Cr-Commit-Position: refs/heads/master@{#480347}
Committed: https://chromium.googlesource.com/chromium/src/+/f9cc972addbcd3f856a0bfc595d1bf62c0824f82

[Timothy Loh, 2017-06-15 04:09:46]

timloh@chromium.org changed reviewers:
+ raymes@chromium.org

[Timothy Loh, 2017-06-15 04:09:46]

Missed this when implementing the persist toggle.

[Timothy Loh, 2017-06-15 04:13:24]

Description was changed from

==========
Hook up persist toggle UMA for PRM codepath

BUG=606138
==========

to

==========
Hook up persist toggle UMA for PermissionRequestManager on Android

This patch wires up UMA for the persist toggle, for when the
PermissionRequestManager is enabled on Android, as the current
implementation is in the PermissionInfoBarDelegate. Both InfoBars and
Dialogs will record UMA as they both delegate to the PermissionPrompt.

BUG=606138
==========

[raymes, 2017-06-15 04:41:36]

https://codereview.chromium.org/2941013002/diff/1/chrome/browser/permissions/...
File chrome/browser/permissions/permission_prompt_android.cc (right):

https://codereview.chromium.org/2941013002/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_prompt_android.cc:22: :
web_contents_(web_contents), delegate_(nullptr) {
nit: initialize persist_

https://codereview.chromium.org/2941013002/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_prompt_android.cc:91:
request->GetContentSettingsType(), persist_);
Dom said there is a way to test the histograms from instrumentation tests using
RecordHistogram.getHistogramValueCountForTesting. It may be good to do that.

[Timothy Loh, 2017-06-15 06:00:55]

The CQ bit was checked by timloh@chromium.org to run a CQ dry run

[Timothy Loh, 2017-06-15 06:00:58]

https://codereview.chromium.org/2941013002/diff/1/chrome/browser/permissions/...
File chrome/browser/permissions/permission_prompt_android.cc (right):

https://codereview.chromium.org/2941013002/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_prompt_android.cc:22: :
web_contents_(web_contents), delegate_(nullptr) {
On 2017/06/15 04:41:36, raymes wrote:
> nit: initialize persist_

Done.

https://codereview.chromium.org/2941013002/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_prompt_android.cc:91:
request->GetContentSettingsType(), persist_);
On 2017/06/15 04:41:36, raymes wrote:
> Dom said there is a way to test the histograms from instrumentation tests
using
> RecordHistogram.getHistogramValueCountForTesting. It may be good to do that.

I added an assert in GeolocationTest.java, could do the same in MediaTest but
would require changing a bit more.

[commit-bot: I haz the power, 2017-06-15 06:01:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 06:50:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 06:50:19]

Dry run: This issue passed the CQ dry run.

[raymes, 2017-06-19 00:51:17]

lgtm

[Timothy Loh, 2017-06-19 03:22:46]

timloh@chromium.org changed reviewers:
+ dominickn@chromium.org

[Timothy Loh, 2017-06-19 03:22:47]

+dominickn@ for
chrome/android/javatests/src/org/chromium/chrome/browser/permissions/GeolocationTest.java
OWNERS

[dominickn, 2017-06-19 03:26:41]

lgtm

[Timothy Loh, 2017-06-19 03:45:27]

The CQ bit was checked by timloh@chromium.org

[commit-bot: I haz the power, 2017-06-19 03:45:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 04:33:10]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497843927057440,
"parent_rev": "38be868490ba34578d64c91e4eebdc44bef9b5cd", "commit_rev":
"f9cc972addbcd3f856a0bfc595d1bf62c0824f82"}

[commit-bot: I haz the power, 2017-06-19 04:33:22]

Description was changed from

==========
Hook up persist toggle UMA for PermissionRequestManager on Android

This patch wires up UMA for the persist toggle, for when the
PermissionRequestManager is enabled on Android, as the current
implementation is in the PermissionInfoBarDelegate. Both InfoBars and
Dialogs will record UMA as they both delegate to the PermissionPrompt.

BUG=606138
==========

to

==========
Hook up persist toggle UMA for PermissionRequestManager on Android

This patch wires up UMA for the persist toggle, for when the
PermissionRequestManager is enabled on Android, as the current
implementation is in the PermissionInfoBarDelegate. Both InfoBars and
Dialogs will record UMA as they both delegate to the PermissionPrompt.

BUG=606138

Review-Url: https://codereview.chromium.org/2941013002
Cr-Commit-Position: refs/heads/master@{#480347}
Committed:
https://chromium.googlesource.com/chromium/src/+/f9cc972addbcd3f856a0bfc595d1...
==========

[commit-bot: I haz the power, 2017-06-19 04:33:24]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f9cc972addbcd3f856a0bfc595d1...