chrome/browser/permissions/permission_prompt_android.h - Issue 2941013002: Hook up persist toggle UMA for PermissionRequestManager on Android

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/permissions/permission_prompt_android.h

Issue 2941013002: Hook up persist toggle UMA for PermissionRequestManager on Android (Closed)

Patch Set: address comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/permissions/GeolocationTest.java ('k') | chrome/browser/permissions/permission_prompt_android.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_PERMISSIONS_PERMISSION_PROMPT_ANDROID_H_	5 #ifndef CHROME_BROWSER_PERMISSIONS_PERMISSION_PROMPT_ANDROID_H_

6 #define CHROME_BROWSER_PERMISSIONS_PERMISSION_PROMPT_ANDROID_H_	6 #define CHROME_BROWSER_PERMISSIONS_PERMISSION_PROMPT_ANDROID_H_

7	7

8 #include <vector>	8 #include <vector>

9	9

10 #include "base/strings/string16.h"	10 #include "base/strings/string16.h"

(...skipping 36 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
47 GURL GetLinkURL() const;	47 GURL GetLinkURL() const;

48	48

49 private:	49 private:

50 // PermissionPromptAndroid is owned by PermissionRequestManager, so it should	50 // PermissionPromptAndroid is owned by PermissionRequestManager, so it should

51 // be safe to hold a raw WebContents pointer here because this class is	51 // be safe to hold a raw WebContents pointer here because this class is

52 // destroyed before the WebContents.	52 // destroyed before the WebContents.

53 content::WebContents* web_contents_;	53 content::WebContents* web_contents_;

54 // \|delegate_\| is the PermissionRequestManager, which owns this object.	54 // \|delegate_\| is the PermissionRequestManager, which owns this object.

55 Delegate* delegate_;	55 Delegate* delegate_;

56	56

	57 bool persist_;

	58

57 DISALLOW_COPY_AND_ASSIGN(PermissionPromptAndroid);	59 DISALLOW_COPY_AND_ASSIGN(PermissionPromptAndroid);

58 };	60 };

59	61

60 #endif // CHROME_BROWSER_PERMISSIONS_PERMISSION_PROMPT_ANDROID_H_	62 #endif // CHROME_BROWSER_PERMISSIONS_PERMISSION_PROMPT_ANDROID_H_

OLD	NEW