Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/permissions/GeolocationTest.java

Issue 2941013002: Hook up persist toggle UMA for PermissionRequestManager on Android (Closed)
Patch Set: address comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/permissions/permission_prompt_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/permissions/GeolocationTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/permissions/GeolocationTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/permissions/GeolocationTest.java
index 8907b3c7c1457acb4b312245850e8c30634e8ac9..5b07983d5a99c571da6f02931cdcf120300e1122 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/permissions/GeolocationTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/permissions/GeolocationTest.java
@@ -7,6 +7,9 @@ package org.chromium.chrome.browser.permissions;
import android.support.test.filters.LargeTest;
import android.support.test.filters.MediumTest;
+import org.junit.Assert;
+
+import org.chromium.base.metrics.RecordHistogram;
import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.RetryOnFailure;
@@ -29,6 +32,8 @@ public class GeolocationTest extends PermissionTestCaseBase {
private static final double LONGITUDE = 0.23;
private static final float ACCURACY = 10;
private static final String TEST_FILE = "/content/test/data/android/geolocation.html";
+ private static final String PERSIST_ACCEPT_HISTOGRAM =
+ "Permissions.Prompt.Accepted.Persisted.Geolocation";
public GeolocationTest() {}
@@ -47,6 +52,12 @@ public class GeolocationTest extends PermissionTestCaseBase {
runAllowTest(updateWaiter, TEST_FILE, javascript, nUpdates, withGesture, isDialog,
hasSwitch, toggleSwitch);
tab.removeObserver(updateWaiter);
+ if (hasSwitch) {
+ int bucket = toggleSwitch ? 0 : 1;
+ Assert.assertEquals(1,
+ RecordHistogram.getHistogramValueCountForTesting(
+ PERSIST_ACCEPT_HISTOGRAM, bucket));
+ }
}
/**
« no previous file with comments | « no previous file | chrome/browser/permissions/permission_prompt_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698