MD Bookmarks: Lazily render dropdown menus

MD Bookmarks: Lazily render dropdown menus

This defers rendering the dropdown menus from the toolbar and command
manager until they are actually needed. This saves a small amount of time
(~10ms) during page load.

BUG=727177
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2940233003
Cr-Commit-Position: refs/heads/master@{#481425}
Committed: https://chromium.googlesource.com/chromium/src/+/9b9aa15f7c29fc3184868e63b1a9e6abb6d43d73

[tsergeant, 2017-06-16 05:59:12]

Description was changed from

==========
MD Bookmarks: Lazily render dropdown menus

This defers rendering the dropdown menus from the toolbar and command
manager until they are actually needed. This saves a small amount of time
(~10ms) from page load time.

BUG=727177
==========

to

==========
MD Bookmarks: Lazily render dropdown menus

This defers rendering the dropdown menus from the toolbar and command
manager until they are actually needed. This saves a small amount of time
(~10ms) from page load time.

BUG=727177
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2017-06-16 06:10:16]

Description was changed from

==========
MD Bookmarks: Lazily render dropdown menus

This defers rendering the dropdown menus from the toolbar and command
manager until they are actually needed. This saves a small amount of time
(~10ms) from page load time.

BUG=727177
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Bookmarks: Lazily render dropdown menus

This defers rendering the dropdown menus from the toolbar and command
manager until they are actually needed. This saves a small amount of time
(~10ms) during page load.

BUG=727177
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2017-06-16 06:10:21]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[tsergeant, 2017-06-16 06:10:36]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[commit-bot: I haz the power, 2017-06-16 06:10:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 06:12:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 06:12:42]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tsergeant, 2017-06-19 03:20:50]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-19 03:20:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2017-06-19 03:34:41]

On 2017/06/16 06:10:37, tsergeant wrote:

Eugh, I'm seeing some issues with the command manager dropdown positioning with
this CL.

Hold off on reviewing it for the moment.

[commit-bot: I haz the power, 2017-06-19 04:34:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 04:34:55]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2017-06-20 04:01:59]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 04:02:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 05:47:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 05:47:07]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2017-06-20 07:43:14]

Alright, this is now fixed (with a flush 😓). PTAL

[calamity, 2017-06-21 08:38:27]

lgtm

https://codereview.chromium.org/2940233003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/toolbar.js (right):

https://codereview.chromium.org/2940233003/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/toolbar.js:81: var menu = /** @type
{!CrActionMenuElement} */ (this.$.dropdown.get());
Why does this not require an immediate flush?

[tsergeant, 2017-06-22 00:10:12]

https://codereview.chromium.org/2940233003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/toolbar.js (right):

https://codereview.chromium.org/2940233003/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/toolbar.js:81: var menu = /** @type
{!CrActionMenuElement} */ (this.$.dropdown.get());
On 2017/06/21 08:38:27, calamity wrote:
> Why does this not require an immediate flush?

The flush() is only needed to work with the dom-repeat, forcing the dom-repeat
to render its elements before the menu is positioned and shown.

Since this menu doesn't have a dom-repeat, all of its menu items will be
synchronously rendered during get().

[tsergeant, 2017-06-22 00:10:22]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2017-06-22 00:10:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 00:13:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 00:13:08]

Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[tsergeant, 2017-06-22 00:26:49]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2017-06-22 00:26:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
calamity@chromium.org
Link to the patchset: https://codereview.chromium.org/2940233003/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-06-22 00:27:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 02:18:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 02:18:29]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
build has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[tsergeant, 2017-06-22 02:47:49]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2017-06-22 02:48:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 03:22:29]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1498099669996400,
"parent_rev": "1e84e7da7c1503c959d7fc1f84aaa1c25d9edcc5", "commit_rev":
"9b9aa15f7c29fc3184868e63b1a9e6abb6d43d73"}

[commit-bot: I haz the power, 2017-06-22 03:22:44]

Description was changed from

==========
MD Bookmarks: Lazily render dropdown menus

This defers rendering the dropdown menus from the toolbar and command
manager until they are actually needed. This saves a small amount of time
(~10ms) during page load.

BUG=727177
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Bookmarks: Lazily render dropdown menus

This defers rendering the dropdown menus from the toolbar and command
manager until they are actually needed. This saves a small amount of time
(~10ms) during page load.

BUG=727177
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2940233003
Cr-Commit-Position: refs/heads/master@{#481425}
Committed:
https://chromium.googlesource.com/chromium/src/+/9b9aa15f7c29fc3184868e63b1a9...
==========

[commit-bot: I haz the power, 2017-06-22 03:22:46]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/9b9aa15f7c29fc3184868e63b1a9...